From: Alexander Aring <alex.aring@gmail.com>
To: Martin Townsend <martin.townsend@xsilon.com>
Cc: linux-zigbee-devel@lists.sourceforge.net,
linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
marcel@holtmann.org
Subject: Re: [PATCH v2 bluetooth] 6lowpan: fix incorrect return values in lowpan_rcv
Date: Mon, 15 Sep 2014 13:50:21 +0200 [thread overview]
Message-ID: <20140915115019.GB13603@omega> (raw)
In-Reply-To: <5416C8B3.9020302@xsilon.com>
On Mon, Sep 15, 2014 at 12:08:35PM +0100, Martin Townsend wrote:
> Hi Alex,
>
...
> > Also here that's too broken here. In lowpan_give_skb_to_devices we have
> > mixed errno and NET_RX_SUCCESS for the return variable, we need to
> > clean this up. Maybe just return the NET_RX_SUCCESS|NET_RX_DROP return
> > value from netif_rx call.
> ok, shall i just do a
> return lowpan_give_skb_to_devices(skb);
>
> and then add the code from freeing or consuming the skb in lowpan_give_skb_to_devices?
>
yes, great idea.
- Alex
prev parent reply other threads:[~2014-09-15 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 9:34 [PATCH v2 bluetooth] Fix lowpan_rcv Martin Townsend
2014-09-12 9:34 ` Martin Townsend
2014-09-12 9:34 ` [PATCH v2 bluetooth] 6lowpan: fix incorrect return values in lowpan_rcv Martin Townsend
2014-09-15 10:13 ` Alexander Aring
2014-09-15 10:24 ` Alexander Aring
2014-09-15 11:08 ` Martin Townsend
2014-09-15 11:50 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915115019.GB13603@omega \
--to=alex.aring@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=marcel@holtmann.org \
--cc=martin.townsend@xsilon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox