From: Johan Hedberg <johan.hedberg@gmail.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, jukka.rissanen@linux.intel.com
Subject: Re: [PATCH bluetooth-next] bluetooth: 6lowpan: fix skb_unshare behaviour
Date: Wed, 8 Oct 2014 11:37:06 +0300 [thread overview]
Message-ID: <20141008083706.GA13231@t440s.lan> (raw)
In-Reply-To: <1412756693-19410-1-git-send-email-alex.aring@gmail.com>
Hi Alex,
On Wed, Oct 08, 2014, Alexander Aring wrote:
> This patch reverts commit:
>
> a7807d73 ("Bluetooth: 6lowpan: Avoid memory leak if memory allocation
> fails")
>
> which was wrong suggested by Alexander Aring. The function skb_unshare
> run also kfree_skb on failure.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> compile tested only.
>
> net/bluetooth/6lowpan.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
This doesn't look like something that should only go to bluetooth-next
(which you've tagged it for). The bluetooth-next tree (since 3.17 has
been released) has moved to catering 3.19 patches whereas this patch
seems to be something that's fixing an issue heading to 3.18-rc1. So it
seems to me this patch should in fact be going to the bluetooth.git tree
instead of bluetooth-next.git. Am I right?
Johan
next prev parent reply other threads:[~2014-10-08 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 8:24 [PATCH bluetooth-next] bluetooth: 6lowpan: fix skb_unshare behaviour Alexander Aring
2014-10-08 8:37 ` Johan Hedberg [this message]
2014-10-08 8:47 ` Alexander Aring
2014-10-09 7:57 ` Johan Hedberg
2014-11-08 19:03 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008083706.GA13231@t440s.lan \
--to=johan.hedberg@gmail.com \
--cc=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).