From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 8 Oct 2014 11:37:06 +0300 From: Johan Hedberg To: Alexander Aring Cc: linux-bluetooth@vger.kernel.org, jukka.rissanen@linux.intel.com Subject: Re: [PATCH bluetooth-next] bluetooth: 6lowpan: fix skb_unshare behaviour Message-ID: <20141008083706.GA13231@t440s.lan> References: <1412756693-19410-1-git-send-email-alex.aring@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1412756693-19410-1-git-send-email-alex.aring@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Alex, On Wed, Oct 08, 2014, Alexander Aring wrote: > This patch reverts commit: > > a7807d73 ("Bluetooth: 6lowpan: Avoid memory leak if memory allocation > fails") > > which was wrong suggested by Alexander Aring. The function skb_unshare > run also kfree_skb on failure. > > Signed-off-by: Alexander Aring > --- > compile tested only. > > net/bluetooth/6lowpan.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) This doesn't look like something that should only go to bluetooth-next (which you've tagged it for). The bluetooth-next tree (since 3.17 has been released) has moved to catering 3.19 patches whereas this patch seems to be something that's fixing an issue heading to 3.18-rc1. So it seems to me this patch should in fact be going to the bluetooth.git tree instead of bluetooth-next.git. Am I right? Johan