From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 3/3] bnep: Return errno instead of -1 and print error
Date: Wed, 22 Oct 2014 16:37:44 +0300 [thread overview]
Message-ID: <20141022133742.GA14103@aemeltch-MOBL1> (raw)
In-Reply-To: <CAMv5Gbck+=b9kY-s+gd3shJsLUDAEZib5dKGM09ZBWkP==ufFw@mail.gmail.com>
Hi Grzegorz,
On Wed, Oct 22, 2014 at 02:55:54PM +0200, Grzegorz Kolodziejczyk wrote:
> Hi Andrei,
>
> On 22 October 2014 13:10, Andrei Emeltchenko
> <Andrei.Emeltchenko.news@gmail.com> wrote:
> > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> >
> > Make code consistent with the rest returning -errno and printing error
> > message.
> > ---
> > profiles/network/bnep.c | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/profiles/network/bnep.c b/profiles/network/bnep.c
> > index 4cf38d9..09d4b65 100644
> > --- a/profiles/network/bnep.c
> > +++ b/profiles/network/bnep.c
> > @@ -231,7 +231,7 @@ static int bnep_if_down(const char *devname)
> > if (ioctl(sk, SIOCSIFFLAGS, (void *) &ifr) < 0) {
> > err = -errno;
> > error("bnep: Could not bring down %s: %s(%d)",
> > - devname, strerror(-err), -err);
> > + devname, strerror(-err), -err);
>
> Why don't you fix this indention in first patch ? (this line is added
> in previous patch)
Sorry, resend the series.
Best regards
Andrei Emeltchenko
prev parent reply other threads:[~2014-10-22 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 11:10 [PATCH 1/3] bnep: Add error print and return errno instead of -1 Andrei Emeltchenko
2014-10-22 11:10 ` [PATCH 2/3] bnep: trivial: code cleanup Andrei Emeltchenko
2014-10-22 11:10 ` [PATCH 3/3] bnep: Return errno instead of -1 and print error Andrei Emeltchenko
2014-10-22 12:55 ` Grzegorz Kolodziejczyk
2014-10-22 13:34 ` [PATCHv2 1/3] bnep: Add error print and return errno instead of -1 Andrei Emeltchenko
2014-10-22 13:34 ` [PATCHv2 2/3] bnep: trivial: code cleanup Andrei Emeltchenko
2014-10-22 13:34 ` [PATCHv2 3/3] bnep: Return errno instead of -1 and print error Andrei Emeltchenko
2014-10-23 10:23 ` [PATCHv2 1/3] bnep: Add error print and return errno instead of -1 Luiz Augusto von Dentz
2014-10-22 13:37 ` Andrei Emeltchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022133742.GA14103@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=grzegorz.kolodziejczyk@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox