From: Alexander Aring <alex.aring@gmail.com>
To: Martin Townsend <mtownsend1973@gmail.com>
Cc: linux-wpan@vger.kernel.org, linux-bluetooth@vger.kernel.org,
jukka.rissanen@linux.intel.com, marcel@holtmann.org
Subject: Re: [PATCHv2 bluetooth-next] 6lowpan: move skb_free from error paths in decompression
Date: Thu, 6 Nov 2014 20:26:42 +0100 [thread overview]
Message-ID: <20141106192639.GC2321@omega> (raw)
In-Reply-To: <1415301313-32290-1-git-send-email-mtownsend1973@gmail.com>
Hi Martin,
On Thu, Nov 06, 2014 at 07:15:13PM +0000, Martin Townsend wrote:
> Currently we ensure that the skb is freed on every error path in IPHC
> decompression which makes it easy to introduce skb leaks. By centralising
> the skb_free into the receive function it makes future decompression routines
> easier to maintain. It does come at the expense of ensuring that the skb
> passed into the decompression routine must not be copied.
>
> Signed-off-by: Martin Townsend <mtownsend1973@gmail.com>
so far I understand is that Jukka already acked this patch. So you
could also add Acked-by: Jukka ... before sending this patch.
Nevertheless you will have also an ack from me now:
Acked-by: Alexander Aring <alex.aring@gmail.com>
- Alex
next prev parent reply other threads:[~2014-11-06 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 19:15 [PATCHv2 bluetooth-next] 6lowpan: move skb_free from error paths in decompression Martin Townsend
2014-11-06 19:26 ` Alexander Aring [this message]
2014-11-06 21:11 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106192639.GC2321@omega \
--to=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mtownsend1973@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox