* [PATCH] Bluetooth: Send mgmt_connected only if state is BT_CONFIG
@ 2014-11-07 11:09 Jaganath Kanakkassery
2014-11-07 13:46 ` Johan Hedberg
0 siblings, 1 reply; 3+ messages in thread
From: Jaganath Kanakkassery @ 2014-11-07 11:09 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Jaganath Kanakkassery
If a remote name request is initiated while acl connection is going on,
and if it fails then mgmt_connected will be sent. Evetually after acl
connection, authentication will not be initiated and userspace will
never get pairing reply.
< HCI Command: Create Connection (0x01|0x0005) plen 13
bdaddr AA:BB:CC:DD:EE:FF ptype 0xcc18 rswitch 0x01 clkoffset 0x2306 (valid)
Packet type: DM1 DM3 DM5 DH1 DH3 DH5
> HCI Event: Command Status (0x0f) plen 4
Create Connection (0x01|0x0005) status 0x00 ncmd 1
> HCI Event: Inquiry Complete (0x01) plen 1
status 0x00
< HCI Command: Remote Name Request (0x01|0x0019) plen 10
bdaddr AA:BB:CC:DD:EE:FF mode 1 clkoffset 0x2306
> HCI Event: Command Status (0x0f) plen 4
Remote Name Request (0x01|0x0019) status 0x0c ncmd 1
Error: Command Disallowed
> HCI Event: Connect Complete (0x03) plen 11
status 0x00 handle 50 bdaddr 00:0D:FD:47:53:B2 type ACL encrypt 0x00
< HCI Command: Read Remote Supported Features (0x01|0x001b) plen 2
handle 50
> HCI Event: Command Status (0x0f) plen 4
Read Remote Supported Features (0x01|0x001b) status 0x00 ncmd 1
> HCI Event: Max Slots Change (0x1b) plen 3
handle 50 slots 5
> HCI Event: Read Remote Supported Features (0x0b) plen 11
status 0x00 handle 50
Features: 0xff 0xff 0x8f 0xfe 0x9b 0xff 0x59 0x83
< HCI Command: Read Remote Extended Features (0x01|0x001c) plen 3
handle 50 page 1
> HCI Event: Command Status (0x0f) plen 4
Read Remote Extended Features (0x01|0x001c) status 0x00 ncmd 1
> HCI Event: Read Remote Extended Features (0x23) plen 13
status 0x00 handle 50 page 1 max 1
Features: 0x01 0x00 0x00 0x00 0x00 0x00 0x00 0x00
This patch sends mgmt_connected in remote name command status only if conn->state
is BT_CONFIG
Signed-off-by: Jaganath Kanakkassery <jaganath.k@samsung.com>
---
net/bluetooth/hci_event.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 5e7be80..68c882f 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1581,7 +1581,8 @@ static void hci_check_pending_name(struct hci_dev *hdev, struct hci_conn *conn,
struct discovery_state *discov = &hdev->discovery;
struct inquiry_entry *e;
- if (conn && !test_and_set_bit(HCI_CONN_MGMT_CONNECTED, &conn->flags))
+ if (conn && conn->state == BT_CONFIG &&
+ !test_and_set_bit(HCI_CONN_MGMT_CONNECTED, &conn->flags))
mgmt_device_connected(hdev, conn, 0, name, name_len);
if (discov->state == DISCOVERY_STOPPED)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Send mgmt_connected only if state is BT_CONFIG
2014-11-07 11:09 [PATCH] Bluetooth: Send mgmt_connected only if state is BT_CONFIG Jaganath Kanakkassery
@ 2014-11-07 13:46 ` Johan Hedberg
2014-11-10 15:15 ` Johan Hedberg
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hedberg @ 2014-11-07 13:46 UTC (permalink / raw)
To: Jaganath Kanakkassery; +Cc: linux-bluetooth
Hi Jaganath,
On Fri, Nov 07, 2014, Jaganath Kanakkassery wrote:
> If a remote name request is initiated while acl connection is going on,
> and if it fails then mgmt_connected will be sent. Evetually after acl
> connection, authentication will not be initiated and userspace will
> never get pairing reply.
>
> < HCI Command: Create Connection (0x01|0x0005) plen 13
> bdaddr AA:BB:CC:DD:EE:FF ptype 0xcc18 rswitch 0x01 clkoffset 0x2306 (valid)
> Packet type: DM1 DM3 DM5 DH1 DH3 DH5
> > HCI Event: Command Status (0x0f) plen 4
> Create Connection (0x01|0x0005) status 0x00 ncmd 1
> > HCI Event: Inquiry Complete (0x01) plen 1
> status 0x00
> < HCI Command: Remote Name Request (0x01|0x0019) plen 10
> bdaddr AA:BB:CC:DD:EE:FF mode 1 clkoffset 0x2306
> > HCI Event: Command Status (0x0f) plen 4
> Remote Name Request (0x01|0x0019) status 0x0c ncmd 1
> Error: Command Disallowed
> > HCI Event: Connect Complete (0x03) plen 11
> status 0x00 handle 50 bdaddr 00:0D:FD:47:53:B2 type ACL encrypt 0x00
> < HCI Command: Read Remote Supported Features (0x01|0x001b) plen 2
> handle 50
> > HCI Event: Command Status (0x0f) plen 4
> Read Remote Supported Features (0x01|0x001b) status 0x00 ncmd 1
> > HCI Event: Max Slots Change (0x1b) plen 3
> handle 50 slots 5
> > HCI Event: Read Remote Supported Features (0x0b) plen 11
> status 0x00 handle 50
> Features: 0xff 0xff 0x8f 0xfe 0x9b 0xff 0x59 0x83
> < HCI Command: Read Remote Extended Features (0x01|0x001c) plen 3
> handle 50 page 1
> > HCI Event: Command Status (0x0f) plen 4
> Read Remote Extended Features (0x01|0x001c) status 0x00 ncmd 1
> > HCI Event: Read Remote Extended Features (0x23) plen 13
> status 0x00 handle 50 page 1 max 1
> Features: 0x01 0x00 0x00 0x00 0x00 0x00 0x00 0x00
>
> This patch sends mgmt_connected in remote name command status only if conn->state
> is BT_CONFIG
>
> Signed-off-by: Jaganath Kanakkassery <jaganath.k@samsung.com>
> ---
> net/bluetooth/hci_event.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to bluetooth-next. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: Send mgmt_connected only if state is BT_CONFIG
2014-11-07 13:46 ` Johan Hedberg
@ 2014-11-10 15:15 ` Johan Hedberg
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2014-11-10 15:15 UTC (permalink / raw)
To: Jaganath Kanakkassery, linux-bluetooth
Hi Jaganath,
> On Fri, Nov 07, 2014, Jaganath Kanakkassery wrote:
> > If a remote name request is initiated while acl connection is going on,
> > and if it fails then mgmt_connected will be sent. Evetually after acl
> > connection, authentication will not be initiated and userspace will
> > never get pairing reply.
> >
> > < HCI Command: Create Connection (0x01|0x0005) plen 13
> > bdaddr AA:BB:CC:DD:EE:FF ptype 0xcc18 rswitch 0x01 clkoffset 0x2306 (valid)
> > Packet type: DM1 DM3 DM5 DH1 DH3 DH5
> > > HCI Event: Command Status (0x0f) plen 4
> > Create Connection (0x01|0x0005) status 0x00 ncmd 1
> > > HCI Event: Inquiry Complete (0x01) plen 1
> > status 0x00
> > < HCI Command: Remote Name Request (0x01|0x0019) plen 10
> > bdaddr AA:BB:CC:DD:EE:FF mode 1 clkoffset 0x2306
> > > HCI Event: Command Status (0x0f) plen 4
> > Remote Name Request (0x01|0x0019) status 0x0c ncmd 1
> > Error: Command Disallowed
> > > HCI Event: Connect Complete (0x03) plen 11
> > status 0x00 handle 50 bdaddr 00:0D:FD:47:53:B2 type ACL encrypt 0x00
> > < HCI Command: Read Remote Supported Features (0x01|0x001b) plen 2
> > handle 50
> > > HCI Event: Command Status (0x0f) plen 4
> > Read Remote Supported Features (0x01|0x001b) status 0x00 ncmd 1
> > > HCI Event: Max Slots Change (0x1b) plen 3
> > handle 50 slots 5
> > > HCI Event: Read Remote Supported Features (0x0b) plen 11
> > status 0x00 handle 50
> > Features: 0xff 0xff 0x8f 0xfe 0x9b 0xff 0x59 0x83
> > < HCI Command: Read Remote Extended Features (0x01|0x001c) plen 3
> > handle 50 page 1
> > > HCI Event: Command Status (0x0f) plen 4
> > Read Remote Extended Features (0x01|0x001c) status 0x00 ncmd 1
> > > HCI Event: Read Remote Extended Features (0x23) plen 13
> > status 0x00 handle 50 page 1 max 1
> > Features: 0x01 0x00 0x00 0x00 0x00 0x00 0x00 0x00
> >
> > This patch sends mgmt_connected in remote name command status only if conn->state
> > is BT_CONFIG
> >
> > Signed-off-by: Jaganath Kanakkassery <jaganath.k@samsung.com>
> > ---
> > net/bluetooth/hci_event.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Applied to bluetooth-next. Thanks.
This patch ended up having a quite severe regression that you could have
caught if you would have run mgmt-tester. As a maintainer I also failed
to run it too before applying. If you had done that you would have seen
the "Get Conn Info - Success" test case timing out. The reason is that
you were failing to also consider BT_CONNECTED state for incoming
connections.
In the future please use our user space end-to-end testers to check for
regressions, and if you add new features for which there are no existing
tests send patches to add those tests. Anyway, I've just sent a patch to
fix this one so no further action needed this time.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-10 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-07 11:09 [PATCH] Bluetooth: Send mgmt_connected only if state is BT_CONFIG Jaganath Kanakkassery
2014-11-07 13:46 ` Johan Hedberg
2014-11-10 15:15 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).