From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] shared/gatt: Fix dereference before NULL check warnings
Date: Thu, 27 Nov 2014 14:58:23 +0200 [thread overview]
Message-ID: <20141127125823.GA29742@t440s> (raw)
In-Reply-To: <1416489195-26477-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Thu, Nov 20, 2014, Andrei Emeltchenko wrote:
> Add NULL check otherwise constructions like below give warnings:
> ...
> uint8_t pdu[4 + get_uuid_len(uuid)];
>
> if (!att || !uuid || uuid->type == BT_UUID_UNSPEC)
> ...
> ---
> src/shared/gatt-helpers.c | 3 +++
> 1 file changed, 3 insertions(+)
Both patches in this set have been applied. Thanks.
Johan
prev parent reply other threads:[~2014-11-27 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 13:13 [PATCH 1/2] shared/gatt: Fix dereference before NULL check warnings Andrei Emeltchenko
2014-11-20 13:13 ` [PATCH 2/2] tools/gatt: Fix memory leak Andrei Emeltchenko
2014-11-27 9:04 ` [PATCH 1/2] shared/gatt: Fix dereference before NULL check warnings Andrei Emeltchenko
2014-11-27 12:58 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127125823.GA29742@t440s \
--to=johan.hedberg@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox