From: Johan Hedberg <johan.hedberg@gmail.com>
To: Scott James Remnant <scott@netsplit.com>
Cc: linux-bluetooth@vger.kernel.org, keybuk@chromium.org
Subject: Re: [PATCH] core: add D-Bus property for TxPower
Date: Mon, 8 Dec 2014 20:39:51 +0200 [thread overview]
Message-ID: <20141208183951.GA16755@t440s.ger.corp.intel.com> (raw)
In-Reply-To: <1411599462-8680-1-git-send-email-scott@netsplit.com>
Hi Scott,
On Wed, Sep 24, 2014, Scott James Remnant wrote:
> This is presented as a raw property rather than a parsed "PathLoss"
> property because in the case of many devices, this specific field will
> not be present and instead the TX power will have to be parsed from
> manufacturer-specific data anyway.
>
> It's better therefore to document the Path Loss equation rather than
> hide it.
> ---
> doc/device-api.txt | 12 ++++++++++++
> src/adapter.c | 6 ++++--
> src/device.c | 41 +++++++++++++++++++++++++++++++++++++++++
> src/device.h | 1 +
> 4 files changed, 58 insertions(+), 2 deletions(-)
I don't have any particular objections to this patch except that the
API documentation should be in a separate patch.
Johan
next prev parent reply other threads:[~2014-12-08 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 22:57 [PATCH] core: add D-Bus property for TxPower Scott James Remnant
2014-09-24 22:57 ` [PATCH] core: add D-Bus property for ManufacturerData Scott James Remnant
2014-12-08 18:41 ` Johan Hedberg
2014-09-24 22:57 ` [PATCH] core: add D-Bus property for ServiceData Scott James Remnant
2014-12-08 18:43 ` Johan Hedberg
2014-12-09 9:10 ` Luiz Augusto von Dentz
2014-12-08 18:39 ` Johan Hedberg [this message]
2014-12-08 21:57 ` [PATCH] core: add D-Bus property for TxPower Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208183951.GA16755@t440s.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=keybuk@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=scott@netsplit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).