From: Johan Hedberg <johan.hedberg@gmail.com>
To: Scott James Remnant <scott@netsplit.com>
Cc: linux-bluetooth@vger.kernel.org, keybuk@chromium.org
Subject: Re: [PATCH] core: add D-Bus property for ServiceData
Date: Mon, 8 Dec 2014 20:43:10 +0200 [thread overview]
Message-ID: <20141208184310.GC16755@t440s.ger.corp.intel.com> (raw)
In-Reply-To: <1411599462-8680-3-git-send-email-scott@netsplit.com>
Hi Scott,
On Wed, Sep 24, 2014, Scott James Remnant wrote:
> Since the standard doesn't make any specific requirement that a UUID
> present in a Service Data field be also present in a specific UUIDs
> field, the UUIDs are also added to that list as well.
> ---
> doc/device-api.txt | 9 ++++++
> src/adapter.c | 1 +
> src/device.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/device.h | 1 +
> src/eir.c | 72 +++++++++++++++++++++++++++++++++++++++++++++
> src/eir.h | 11 +++++++
> 6 files changed, 179 insertions(+)
This too looks fine, but the documentation and EIR parsing parts should
be split into their own patches.
Johan
next prev parent reply other threads:[~2014-12-08 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 22:57 [PATCH] core: add D-Bus property for TxPower Scott James Remnant
2014-09-24 22:57 ` [PATCH] core: add D-Bus property for ManufacturerData Scott James Remnant
2014-12-08 18:41 ` Johan Hedberg
2014-09-24 22:57 ` [PATCH] core: add D-Bus property for ServiceData Scott James Remnant
2014-12-08 18:43 ` Johan Hedberg [this message]
2014-12-09 9:10 ` Luiz Augusto von Dentz
2014-12-08 18:39 ` [PATCH] core: add D-Bus property for TxPower Johan Hedberg
2014-12-08 21:57 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208184310.GC16755@t440s.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=keybuk@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=scott@netsplit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).