From: Johan Hedberg <johan.hedberg@gmail.com>
To: Arman Uguray <armansito@chromium.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 07/15] core: device: Use bt_att_register_disconnect.
Date: Tue, 9 Dec 2014 10:07:56 +0200 [thread overview]
Message-ID: <20141209080756.GA4214@t440s.lan> (raw)
In-Reply-To: <1418085655-7304-8-git-send-email-armansito@chromium.org>
Hi Arman,
On Mon, Dec 08, 2014, Arman Uguray wrote:
> + dev->att = bt_att_ref(g_attrib_get_att(attrib));
I'd expect a function called "get" to return a new reference, so the
extra ref() shouldn't be needed.
Btw, I hope this is just a temporary function that you've introduced to
be able to do the conversions in smaller bits, and that it'll be removed
as soon as the conversions are done?
Johan
next prev parent reply other threads:[~2014-12-09 8:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 0:40 [PATCH BlueZ 00/15] core: Use shared/gatt for GATT client role Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 01/15] attrib/gattrib: Add g_attrib_get_att Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 02/15] shared/att: Add bt_att_get_fd Arman Uguray
2014-12-09 12:50 ` Luiz Augusto von Dentz
2014-12-09 13:04 ` Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 03/15] attrib: Check if attrib is NULL in functions Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 04/15] shared/att: cancel_all before calling disconnect cb Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 05/15] shared/gatt-db: Make accessors work on const ptr Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 06/15] shared/gatt-db: Add UUID arg to foreach_service Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 07/15] core: device: Use bt_att_register_disconnect Arman Uguray
2014-12-09 8:07 ` Johan Hedberg [this message]
2014-12-09 13:12 ` Arman Uguray
2014-12-09 15:50 ` Johan Hedberg
2014-12-09 0:40 ` [PATCH BlueZ 08/15] core: device: Use shared/gatt-client for GATT Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 09/15] core: Rename device_attach_attrib Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 10/15] core: Use gatt_db service callbacks Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 11/15] core: Introduce gatt-callbacks Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 12/15] profiles/gatt: Don't handle GATT service Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 13/15] profiles/gatt: Rename profile to gap Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 14/15] profiles/gap: Rewrite using bt_gatt_client Arman Uguray
2014-12-09 0:40 ` [PATCH BlueZ 15/15] profiles/gap: Add Google copyright Arman Uguray
2014-12-09 12:53 ` [PATCH BlueZ 00/15] core: Use shared/gatt for GATT client role Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209080756.GA4214@t440s.lan \
--to=johan.hedberg@gmail.com \
--cc=armansito@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).