linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jakub Pawlowski <jpawlowski@google.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [RFC v4 1/2] Bluetooth: Add le_scan_restart
Date: Tue, 9 Dec 2014 11:01:20 +0200	[thread overview]
Message-ID: <20141209090120.GA5965@t440s.lan> (raw)
In-Reply-To: <CAD0=r8yUn0Z6dQ7XgzpwFysB0Km+q4_cOFU2JfOOs7=3Kd+XOw@mail.gmail.com>

Hi Jakub,

On Tue, Dec 09, 2014, Jakub Pawlowski wrote:
> > Same as we should check for HCI_QUIRK_STRICT_DUPLICATE_FILTER
> > setting and only do the restart scan stuff if the driver told us
> > that this controller is not providing multiple reports.
> 
> So I did some tests on 4 controllers I described in this email:
> http://marc.info/?l=linux-bluetooth&m=141764424929887&w=2
> I think that HCI_QUIRK_STRICT_DUPLICATE_FILTER wil be valid if we were
> doing HCI_OP_INQUIRY, when I was using HCI_OP_LE_SET_SCAN_ENABLE with
> LE_SCAN_FILTER_DUP_ENABLE none of the controllers I used reported
> device twice with different RSSI except for marevell, which seems to
> ignore
> LE_SCAN_FILTER_DUP_ENABLE, and reports all advertisements.
> 
> The way I conducted this tests was to start the scan "tools/mgmt find
> -l", and try to approach (15-20 meters) or move away from scanning
> device, walk back and forth, or just keep the advertiser in place. I
> was monitoring both btmgmt output and dmesg kernel logs (I added some
> additional BT_INFO to make sure I won't miss anything)
> 
> Do you have different experience for LE scan ? Or maybe I just picked
> wrong controllers for my tests ?

Please add CSR dongles to your mix. The most commonly available one is
probably the PTS dongle. They also report multiple advertisements as the
RSSI changes.

Johan

  reply	other threads:[~2014-12-09  9:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 23:43 [RFC v4 1/2] Bluetooth: Add le_scan_restart Jakub Pawlowski
2014-12-05 23:43 ` [RFC v4 2/2] Bluetooth: Add restarting to service discovery Jakub Pawlowski
2014-12-09  6:32   ` Marcel Holtmann
2014-12-09  8:59     ` Jakub Pawlowski
2014-12-09  6:32 ` [RFC v4 1/2] Bluetooth: Add le_scan_restart Marcel Holtmann
2014-12-09  8:32   ` Jakub Pawlowski
2014-12-09  9:01     ` Johan Hedberg [this message]
2014-12-09  9:21       ` Jakub Pawlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141209090120.GA5965@t440s.lan \
    --to=johan.hedberg@gmail.com \
    --cc=jpawlowski@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).