linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Biman Paul <biman.paul@samsung.com>
Cc: linux-bluetooth@vger.kernel.org,
	"'JAGANATH KANAKKASSERY'" <jaganath.k@samsung.com>,
	"'CHETHAN T N'" <chethan.tn@samsung.com>,
	"'Seungyoun Ju'" <sy39.ju@samsung.com>,
	'�þ�' <s.syam@samsung.com>
Subject: Re: MGMT_OP_SET_DISCOVERABLE is queued for a long time if Pairing is in progress
Date: Wed, 17 Dec 2014 11:19:32 +0200	[thread overview]
Message-ID: <20141217091932.GA30012@t440s.lan> (raw)
In-Reply-To: <00a401d019d7$413a57b0$c3af0710$@samsung.com>

Hi,

On Wed, Dec 17, 2014, Biman Paul wrote:
> If the device has initiated pairing and after that it tries to change
> discovery mode, discovery mode change request is queued until the pairing
> operation is completed(be it successful, failed, timeout).
> 
> Steps to Reproduce:
> 1. Initiate Pairing from Instrument Under Test
> 2. Accept in Instrument under Test but do not accept in remote device
> 3. Try to change the Visibility from off to on or on to off.
> Visibility change does not happen until pairing operation is
> completed(Pairing is accepted, rejected or timeout in remote).
> 
> Please suggest the best way we can handle this.

Can't you just enable discoverable mode *before* initiating pairing? :)

On a more serious note, we do have the appropriate API for such
situations: mgmt_reply (instead of mgmt_send) which skips the queue of
mgmt commands. This is how canceling pairing works as well as responding
to PIN or passkey requests (as otherwise these commands would only get
sent when the pair command completes).

So far we haven't extended the use of mgmt_reply anywhere else, but we
could consider using it more extensively when pairing is active if we
have good use cases for it.

Johan

      reply	other threads:[~2014-12-17  9:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17  8:55 MGMT_OP_SET_DISCOVERABLE is queued for a long time if Pairing is in progress Biman Paul
2014-12-17  9:19 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141217091932.GA30012@t440s.lan \
    --to=johan.hedberg@gmail.com \
    --cc=biman.paul@samsung.com \
    --cc=chethan.tn@samsung.com \
    --cc=jaganath.k@samsung.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=s.syam@samsung.com \
    --cc=sy39.ju@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).