Re: [PATCH] android/gatt: Fix dead code warnings

[Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>]

Hi Szymon,

On Fri, Dec 19, 2014 at 11:07:55AM +0100, Szymon Janc wrote:
> Hi Andrei,
> 
> On Friday 19 of December 2014 11:24:40 Andrei Emeltchenko wrote:
> > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > 
> > gatt_db_attribute_get_permissions() used everywhere without check since
> > those conditions are checked already.
> > ---
> >  android/gatt.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/android/gatt.c b/android/gatt.c
> > index 0258d91..169f6db 100644
> > --- a/android/gatt.c
> > +++ b/android/gatt.c
> > @@ -6311,8 +6311,7 @@ static void write_cmd_request(const uint8_t *cmd, uint16_t cmd_len,
> >  	if (!attrib)
> >  		return;
> >  
> > -	if (!gatt_db_attribute_get_permissions(attrib, &permissions))
> > -		return;
> > +	gatt_db_attribute_get_permissions(attrib, &permissions);
> >  
> >  	if (check_device_permissions(dev, cmd[0], permissions))
> >  		return;
> 
> Wasn't identical patch already reviewed few weeks ago?
> 

It is still valid. No better approach was found.

Best regards 
Andrei Emeltchenko