Re: [PATCH 1/2] shared/gatt: Fix NULL dereference

[Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>]

ping

On Fri, Dec 19, 2014 at 11:25:23AM +0200, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> The which is executed after checking (!op) is dereferencing op in
> function discovery_op_free().
> ---
>  src/shared/gatt-client.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
> index f7a90d1..c9fb05d 100644
> --- a/src/shared/gatt-client.c
> +++ b/src/shared/gatt-client.c
> @@ -1075,11 +1075,12 @@ static void process_service_changed(struct bt_gatt_client *client,
>  		return;
>  	}
>  
> +	discovery_op_free(op);
> +
>  fail:
>  	util_debug(client->debug_callback, client->debug_data,
>  					"Failed to initiate service discovery"
>  					" after Service Changed");
> -	discovery_op_free(op);
>  }
>  
>  static void service_changed_cb(uint16_t value_handle, const uint8_t *value,
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html