linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] shared/hfp: Remove dead code
@ 2014-12-22 13:16 Andrei Emeltchenko
  2015-01-07  9:17 ` Andrei Emeltchenko
  2015-01-07  9:51 ` Johan Hedberg
  0 siblings, 2 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2014-12-22 13:16 UTC (permalink / raw)
  To: linux-bluetooth

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Remove dead code since free_tmp initialized to false.
---
 src/shared/hfp.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/shared/hfp.c b/src/shared/hfp.c
index 9d937a5..05a8563 100644
--- a/src/shared/hfp.c
+++ b/src/shared/hfp.c
@@ -1192,10 +1192,6 @@ static void hf_process_input(struct hfp_hf *hfp)
 	if (len == ringbuf_len(hfp->read_buf))
 		goto done;
 
-	/* If we are here second time for some reason, that is wrong */
-	if (free_tmp)
-		goto done;
-
 	str2 = ringbuf_peek(hfp->read_buf, len, &len2);
 	if (!str2)
 		goto done;
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] shared/hfp: Remove dead code
  2014-12-22 13:16 [PATCH] shared/hfp: Remove dead code Andrei Emeltchenko
@ 2015-01-07  9:17 ` Andrei Emeltchenko
  2015-01-07  9:51 ` Johan Hedberg
  1 sibling, 0 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2015-01-07  9:17 UTC (permalink / raw)
  To: linux-bluetooth

ping

On Mon, Dec 22, 2014 at 03:16:51PM +0200, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> Remove dead code since free_tmp initialized to false.
> ---
>  src/shared/hfp.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/shared/hfp.c b/src/shared/hfp.c
> index 9d937a5..05a8563 100644
> --- a/src/shared/hfp.c
> +++ b/src/shared/hfp.c
> @@ -1192,10 +1192,6 @@ static void hf_process_input(struct hfp_hf *hfp)
>  	if (len == ringbuf_len(hfp->read_buf))
>  		goto done;
>  
> -	/* If we are here second time for some reason, that is wrong */
> -	if (free_tmp)
> -		goto done;
> -
>  	str2 = ringbuf_peek(hfp->read_buf, len, &len2);
>  	if (!str2)
>  		goto done;
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] shared/hfp: Remove dead code
  2014-12-22 13:16 [PATCH] shared/hfp: Remove dead code Andrei Emeltchenko
  2015-01-07  9:17 ` Andrei Emeltchenko
@ 2015-01-07  9:51 ` Johan Hedberg
  1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2015-01-07  9:51 UTC (permalink / raw)
  To: Andrei Emeltchenko; +Cc: linux-bluetooth

Hi Andrei,

On Mon, Dec 22, 2014, Andrei Emeltchenko wrote:
> Remove dead code since free_tmp initialized to false.
> ---
>  src/shared/hfp.c | 4 ----
>  1 file changed, 4 deletions(-)

Applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-07  9:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 13:16 [PATCH] shared/hfp: Remove dead code Andrei Emeltchenko
2015-01-07  9:17 ` Andrei Emeltchenko
2015-01-07  9:51 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).