* [PATCH 1/1] tools/bluemoon: Remove dead code
@ 2014-12-30 6:27 Syam Sidhardhan
2015-01-07 20:04 ` Syam Sidhardhan
2015-01-08 9:50 ` Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Syam Sidhardhan @ 2014-12-30 6:27 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Syam Sidhardhan
return statement never get executed after goto.
---
tools/bluemoon.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/bluemoon.c b/tools/bluemoon.c
index 1fd516a..663d1f9 100644
--- a/tools/bluemoon.c
+++ b/tools/bluemoon.c
@@ -776,7 +776,6 @@ static void analyze_firmware(const char *path)
if (len != st.st_size) {
fprintf(stderr, "Failed to read complete firmware file\n");
goto done;
- return;
}
if ((size_t) len < sizeof(*css)) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] tools/bluemoon: Remove dead code
2014-12-30 6:27 [PATCH 1/1] tools/bluemoon: Remove dead code Syam Sidhardhan
@ 2015-01-07 20:04 ` Syam Sidhardhan
2015-01-08 9:50 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Syam Sidhardhan @ 2015-01-07 20:04 UTC (permalink / raw)
To: Syam Sidhardhan; +Cc: User Name
Hi,
On Tue, Dec 30, 2014 at 11:57 AM, Syam Sidhardhan <s.syam@samsung.com> wrote:
> return statement never get executed after goto.
> ---
> tools/bluemoon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/bluemoon.c b/tools/bluemoon.c
> index 1fd516a..663d1f9 100644
> --- a/tools/bluemoon.c
> +++ b/tools/bluemoon.c
> @@ -776,7 +776,6 @@ static void analyze_firmware(const char *path)
> if (len != st.st_size) {
> fprintf(stderr, "Failed to read complete firmware file\n");
> goto done;
> - return;
> }
>
> if ((size_t) len < sizeof(*css)) {
> --
ping
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] tools/bluemoon: Remove dead code
2014-12-30 6:27 [PATCH 1/1] tools/bluemoon: Remove dead code Syam Sidhardhan
2015-01-07 20:04 ` Syam Sidhardhan
@ 2015-01-08 9:50 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2015-01-08 9:50 UTC (permalink / raw)
To: Syam Sidhardhan; +Cc: linux-bluetooth
Hi Syam,
On Tue, Dec 30, 2014, Syam Sidhardhan wrote:
> return statement never get executed after goto.
> ---
> tools/bluemoon.c | 1 -
> 1 file changed, 1 deletion(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-08 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-30 6:27 [PATCH 1/1] tools/bluemoon: Remove dead code Syam Sidhardhan
2015-01-07 20:04 ` Syam Sidhardhan
2015-01-08 9:50 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).