From: Johan Hedberg <johan.hedberg@gmail.com>
To: Arman Uguray <armansito@chromium.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ v1] core: device: Fix bugs in device_browse_gatt
Date: Wed, 28 Jan 2015 10:14:39 +0200 [thread overview]
Message-ID: <20150128081439.GA22704@t440s.lan> (raw)
In-Reply-To: <1422388746-23627-1-git-send-email-armansito@chromium.org>
Hi Arman,
On Tue, Jan 27, 2015, Arman Uguray wrote:
> This patch fixes two issues in GATT service browsing:
>
> 1. There was a bug in gatt_client_ready_cb that broke GAttrib-based
> profiles by not creating gatt_primary structures if no browse request
> exists at the time.
>
> 2. In device_browse_gatt, a response to "Pair" wasn't always being sent
> since the code didn't assign the DBusMessage pointer to the browse_req.
Please split this into two patches since these seem to be independent
issues.
> Change-Id: I9d2b24db19be9c55b971504750a1061df6366e84
And please leave this part out.
Otherwise the actual code changes look good to me.
Johan
next prev parent reply other threads:[~2015-01-28 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 19:59 [PATCH BlueZ v1] core: device: Fix bugs in device_browse_gatt Arman Uguray
2015-01-28 8:14 ` Johan Hedberg [this message]
2015-01-28 13:10 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128081439.GA22704@t440s.lan \
--to=johan.hedberg@gmail.com \
--cc=armansito@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).