From: Adam Lee <adam.lee@canonical.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>
Subject: Re: [PATCH] Bluetooth: ath3k: workaround the compatibility issue with xHCI controller
Date: Wed, 28 Jan 2015 15:26:18 -0500 [thread overview]
Message-ID: <20150128202618.GB2659@adam-laptop> (raw)
In-Reply-To: <A2CF42D4-BB10-404D-B8C4-4E20410AD971@holtmann.org>
On Wed, Jan 28, 2015 at 12:22:51PM -0800, Marcel Holtmann wrote:
> I am still curious why you specified it like this. It would expect something like this:
>
> usleep_range(TIMEGAP_MIN, TIMEGAP_MAX);
>
> Btw. _US seems a bit to unclear if that is suppose to represent usec
> or something chip internal called US. If you want to keep it in there,
> then I prefer _USEC so I do not have to second guess every time I look
> at the code.
>
> Otherwise this is fine. Just use two constants and not some magic
> range calculation.
>
> Regards
>
> Marcel
Good point, will resend, thanks.
--
Adam Lee
prev parent reply other threads:[~2015-01-28 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 19:52 [PATCH] Bluetooth: ath3k: workaround the compatibility issue with xHCI controller Adam Lee
2015-01-28 20:10 ` Marcel Holtmann
2015-01-28 20:16 ` Adam Lee
2015-01-28 20:22 ` Marcel Holtmann
2015-01-28 20:26 ` Adam Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128202618.GB2659@adam-laptop \
--to=adam.lee@canonical.com \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox