Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jakub Pawlowski <jpawlowski@google.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH BlueZ v5] doc/adapter-api.txt: StartFilteredDiscovery method.
Date: Tue, 24 Feb 2015 12:37:53 +0200	[thread overview]
Message-ID: <20150224103753.GA6088@t440s.lan> (raw)
In-Reply-To: <CAD0=r8zStMB6WVf0iGW59rS_x_+c-gmNUmG1OhhdXOatSj_amw@mail.gmail.com>

Hi Jakub,

On Mon, Feb 23, 2015, Jakub Pawlowski wrote:
> > Since we can't any more track multiple different discoveries within the
> > same application (D-Bus connection) the StopDiscovery behavior is now
> > quite broken. The simplest way around that would be to add a discovery
> > instance return parameter to StartServiceDiscovery and to have a new
> > StopServiceDiscovery D-Bus method that'd take this as an input
> > parameter.
> 
> Right now each application can call StartDiscovery only once, I want
> each application to be able to call StartDiscovery OR
> StartFilteredDiscovery only once. This way we are completly fine with
> one StopDiscovery method. If some application needs to change filter,
> it can always stop and restart it's scan.

Actually I remembered wrong how the current code works. I thought it was
allowing multiple StartDiscovery() per app, but there's indeed a
hard-coded limit of just one. Keeping this policy around would allow
StopDiscovery to be used for StartDiscovery and StartServiceDiscovery
alike, and each app would then only be allowed to call one of those at a
time.

Johan

  parent reply	other threads:[~2015-02-24 10:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10  0:34 [PATCH BlueZ v5] doc/adapter-api.txt: StartFilteredDiscovery method Jakub Pawlowski
2015-02-16  8:46 ` Luiz Augusto von Dentz
2015-02-20 17:09   ` Jakub Pawlowski
2015-02-23 13:09   ` Johan Hedberg
2015-02-23 16:41     ` Jakub Pawlowski
2015-02-23 18:43       ` Jakub Pawlowski
2015-02-23 21:43         ` Arman Uguray
2015-02-23 22:44           ` Jakub Pawlowski
2015-02-23 23:07             ` Arman Uguray
2015-02-24  0:01               ` Jakub Pawlowski
2015-02-24 10:51                 ` Johan Hedberg
2015-02-24 10:37       ` Johan Hedberg [this message]
2015-02-24 20:23         ` Jakub Pawlowski
2015-02-24 22:50           ` Marcel Holtmann
2015-02-24 23:12             ` Jakub Pawlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150224103753.GA6088@t440s.lan \
    --to=johan.hedberg@gmail.com \
    --cc=jpawlowski@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox