Re: [PATCHv2] shared/att: Fix boolean check in handle_notify()

[Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>]

ping

On Mon, Jun 01, 2015 at 01:11:43PM +0300, Andrei Emeltchenko wrote:
> ping
> 
> On Fri, May 29, 2015 at 11:53:26AM +0300, Andrei Emeltchenko wrote:
> > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > 
> > ext_signed is boolean and shall be checked with logical op.
> > ---
> >  src/shared/att.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/shared/att.c b/src/shared/att.c
> > index 053aa47..f9a5817 100644
> > --- a/src/shared/att.c
> > +++ b/src/shared/att.c
> > @@ -733,7 +733,7 @@ static void handle_notify(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
> >  	const struct queue_entry *entry;
> >  	bool found;
> >  
> > -	if (opcode & ATT_OP_SIGNED_MASK & !att->ext_signed) {
> > +	if ((opcode & ATT_OP_SIGNED_MASK) && !att->ext_signed) {
> >  		if (!handle_signed(att, opcode, pdu, pdu_len))
> >  			return;
> >  		pdu_len -= BT_ATT_SIGNATURE_LEN;
> > -- 
> > 2.1.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html