Linux bluetooth development
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Lukasz Duda <lukasz.duda@nordicsemi.no>
Cc: linux-wpan@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	Glenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>
Subject: Re: [RFC v2 4/4] Bluetooth: 6lowpan: Enable stateful compression in bluetooth_6lowpan
Date: Thu, 23 Jul 2015 09:55:24 +0200	[thread overview]
Message-ID: <20150723075523.GA19536@omega> (raw)
In-Reply-To: <1436788233-13960-5-git-send-email-lukasz.duda@nordicsemi.no>

On Mon, Jul 13, 2015 at 01:50:33PM +0200, Lukasz Duda wrote:
> Allocating context table for stateful compression when interface is set
> up. Removing context table when interface is being unregistered.
> 
> Signed-off-by: Lukasz Duda <lukasz.duda@nordicsemi.no>
> Signed-off-by: Glenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>
> ---
>  net/bluetooth/6lowpan.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 2fb7b30..60c7e80 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -871,6 +871,9 @@ static int setup_netdev(struct l2cap_chan *chan, struct lowpan_dev **dev)
>  	       &chan->src, chan->src_type);
>  	set_bit(__LINK_STATE_PRESENT, &netdev->state);
>  
> +	/* Allocate context table for stateful compression. */
> +	lowpan_context_table_alloc(netdev);
> +
>  	*dev = netdev_priv(netdev);
>  	(*dev)->netdev = netdev;
>  	(*dev)->hdev = chan->conn->hcon->hdev;
> @@ -1415,6 +1418,7 @@ static int device_event(struct notifier_block *unused,
>  			if (entry->netdev == netdev) {
>  				BT_DBG("Unregistered netdev %s %p",
>  				       netdev->name, netdev);
> +				lowpan_context_table_free(netdev);
>  				list_del(&entry->list);
>  				break;
>  			}

Don't we need similar allocation in net/ieee802154/6lowpan/core.c ?

- Alex

  reply	other threads:[~2015-07-23  7:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 11:50 [RFC v2 0/4] Adding stateful compression to IPHC Lukasz Duda
2015-07-13 11:50 ` [RFC v2 1/4] 6lowpan: Introduce debugfs entry for 6lowpan module Lukasz Duda
2015-07-23  6:07   ` Alexander Aring
2015-07-13 11:50 ` [RFC v2 2/4] 6lowpan: Add stateful compression component of " Lukasz Duda
2015-07-23  6:52   ` Alexander Aring
2015-07-23  6:59     ` Alexander Aring
2015-07-13 11:50 ` [RFC v2 3/4] 6lowpan: Add stateful compression support for iphc.c Lukasz Duda
2015-07-23  7:48   ` Alexander Aring
2015-07-23  8:20     ` Duda, Lukasz
2015-07-13 11:50 ` [RFC v2 4/4] Bluetooth: 6lowpan: Enable stateful compression in bluetooth_6lowpan Lukasz Duda
2015-07-23  7:55   ` Alexander Aring [this message]
2015-07-23  8:09     ` Duda, Lukasz
2015-07-13 13:09 ` [RFC v2 0/4] Adding stateful compression to IPHC Jukka Rissanen
2015-07-15 13:42   ` Duda, Lukasz
2015-07-16  7:25     ` Jukka Rissanen
2015-07-13 14:15 ` Michael Richardson
2015-07-15  9:55 ` Duda, Lukasz
2015-07-23  8:22 ` Alexander Aring
2015-10-12 16:15 ` Alexander Aring
2015-10-13  8:36   ` Duda, Lukasz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150723075523.GA19536@omega \
    --to=alex.aring@gmail.com \
    --cc=glenn.ruben.bakke@nordicsemi.no \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=lukasz.duda@nordicsemi.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox