From: Alexander Aring <alex.aring@gmail.com>
To: Stefan Schmidt <stefan@osg.samsung.com>
Cc: linux-wpan@vger.kernel.org, kernel@pengutronix.de,
linux-bluetooth@vger.kernel.org, lukasz.duda@nordicsemi.no
Subject: Re: [RFC bluetooth-next 1/2] bluetooth: 6lowpan: change netdev_priv to lowpan_dev
Date: Fri, 31 Jul 2015 00:15:50 +0200 [thread overview]
Message-ID: <20150730221549.GA1037@omega> (raw)
In-Reply-To: <55BA7D65.40202@osg.samsung.com>
On Thu, Jul 30, 2015 at 09:39:17PM +0200, Stefan Schmidt wrote:
> Hello.
>
> On 30/07/15 21:36, Stefan Schmidt wrote:
> >Hello.
> >
> >On 29/07/15 14:24, Alexander Aring wrote:
> >>The usually way to get the btle lowpan private data is to use the
> >>introduced lowpan_dev inline function. This patch will cleanup by using
> >>lowpan_dev consequently.
> >>
> >>Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> >>---
> >> net/bluetooth/6lowpan.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> >>index 2fb7b30..93c6ba0 100644
> >>--- a/net/bluetooth/6lowpan.c
> >>+++ b/net/bluetooth/6lowpan.c
> >>@@ -871,7 +871,7 @@ static int setup_netdev(struct l2cap_chan *chan,
> >>struct lowpan_dev **dev)
> >> &chan->src, chan->src_type);
> >> set_bit(__LINK_STATE_PRESENT, &netdev->state);
> >> - *dev = netdev_priv(netdev);
> >>+ *dev = lowpan_dev(netdev);
> >> (*dev)->netdev = netdev;
> >> (*dev)->hdev = chan->conn->hcon->hdev;
> >> INIT_LIST_HEAD(&(*dev)->peers);
> >
> >This patch does no longer apply. There have been 5 patches to the 6lowpan
> >file in bluetooth from Gleen. You need to rebase this one.
> >
> Looking at it in more detail its actually your own patch which makes the
> rebase necessary. The one fixing a possible race.
>
yes, I know. I will send a v2 in the next 24 hours.
- Alex
next prev parent reply other threads:[~2015-07-30 22:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 12:24 [RFC bluetooth-next 0/2] 6lowpan: introduce generic 6lowpan private data Alexander Aring
2015-07-29 12:24 ` [RFC bluetooth-next 1/2] bluetooth: 6lowpan: change netdev_priv to lowpan_dev Alexander Aring
2015-07-30 19:36 ` Stefan Schmidt
2015-07-30 19:39 ` Stefan Schmidt
2015-07-30 22:15 ` Alexander Aring [this message]
2015-07-29 12:24 ` [RFC bluetooth-next 2/2] 6lowpan: add generic 6lowpan netdev private data Alexander Aring
2015-07-30 19:44 ` Stefan Schmidt
2015-07-30 19:31 ` [RFC bluetooth-next 0/2] 6lowpan: introduce generic 6lowpan " Stefan Schmidt
2015-07-31 7:29 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730221549.GA1037@omega \
--to=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=lukasz.duda@nordicsemi.no \
--cc=stefan@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).