From: Johan Hedberg <johan.hedberg@gmail.com>
To: Mariusz Skamra <mariusz.skamra@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5] emulator: Fix LE Connection Complete Event data
Date: Sat, 29 Aug 2015 06:20:25 +0300 [thread overview]
Message-ID: <20150829032025.GA8367@t440s> (raw)
In-Reply-To: <1440690893-30384-1-git-send-email-mariusz.skamra@tieto.com>
Hi Mariusz,
On Thu, Aug 27, 2015, Mariusz Skamra wrote:
> +static void le_conn_complete(struct btdev *btdev, const void *cmd,
> + uint8_t status)
> {
> char buf[1 + sizeof(struct bt_hci_evt_le_conn_complete)];
> struct bt_hci_evt_le_conn_complete *cc = (void *) &buf[1];
> + const struct bt_hci_cmd_le_create_conn *lecc = cmd;
Why the void pointer in the function parameters and then casting it to
the actual one? It'd be simpler and safer if you just passed this as the
right type from the start.
Johan
next prev parent reply other threads:[~2015-08-29 3:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 15:54 [PATCH 1/5] emulator: Fix LE Connection Complete Event data Mariusz Skamra
2015-08-27 15:54 ` [PATCH 2/5] emulator: Update LE supported commands Mariusz Skamra
2015-08-29 3:25 ` Johan Hedberg
2015-08-27 15:54 ` [PATCH 3/5] emulator: Remove duplicated assignment Mariusz Skamra
2015-08-27 15:54 ` [PATCH 4/5] emulator: Add support for LE Remote Connection Parameter Request Reply Mariusz Skamra
2015-08-27 15:54 ` [PATCH 5/5] emulator: Enable Slave-initiated Features Exchange feature Mariusz Skamra
2015-08-29 3:20 ` Johan Hedberg [this message]
2015-08-31 10:09 ` [PATCHv2 1/5] emulator: Remove duplicated assignment Mariusz Skamra
2015-08-31 10:09 ` [PATCHv2 2/5] emulator: Add support for LE Remote Connection Parameter Request Reply Mariusz Skamra
2015-08-31 10:09 ` [PATCHv2 3/5] emulator: Add support for LE Remote Connection Parameter Request Negative Reply Mariusz Skamra
2015-08-31 10:09 ` [PATCHv2 4/5] emulator: Enable Slave-initiated Features Exchange feature Mariusz Skamra
2015-08-31 10:09 ` [PATCHv2 5/5] emulator: Refactor le set scan enable command handler Mariusz Skamra
2015-08-31 10:18 ` [PATCHv2 1/6] emulator: Fix LE Connection Complete Event data Mariusz Skamra
2015-08-31 10:18 ` [PATCHv2 2/6] emulator: Remove duplicated assignment Mariusz Skamra
2015-08-31 10:18 ` [PATCHv2 3/6] emulator: Add support for LE Remote Connection Parameter Request Reply Mariusz Skamra
2015-08-31 10:18 ` [PATCHv2 4/6] emulator: Add support for LE Remote Connection Parameter Request Negative Reply Mariusz Skamra
2015-08-31 10:18 ` [PATCHv2 5/6] emulator: Enable Slave-initiated Features Exchange feature Mariusz Skamra
2015-08-31 10:18 ` [PATCHv2 6/6] emulator: Refactor le set scan enable command handler Mariusz Skamra
-- strict thread matches above, loose matches on Subject: below --
2015-08-31 10:09 [PATCH] emulator: Improve " Mariusz Skamra
2015-08-31 10:13 ` Mariusz Skamra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150829032025.GA8367@t440s \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mariusz.skamra@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).