linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Mariusz Skamra <mariusz.skamra@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/5] emulator: Update LE supported commands
Date: Sat, 29 Aug 2015 06:25:22 +0300	[thread overview]
Message-ID: <20150829032522.GB8367@t440s> (raw)
In-Reply-To: <1440690893-30384-2-git-send-email-mariusz.skamra@tieto.com>

Hi Mariusz,

On Thu, Aug 27, 2015, Mariusz Skamra wrote:
> ---
>  emulator/btdev.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/emulator/btdev.c b/emulator/btdev.c
> index 319d434..b285b2a 100644
> --- a/emulator/btdev.c
> +++ b/emulator/btdev.c
> @@ -420,15 +420,24 @@ static void set_le_commands(struct btdev *btdev)
>  	btdev->commands[25] |= 0x01;	/* LE Set Event Mask */
>  	btdev->commands[25] |= 0x02;	/* LE Read Buffer Size */
>  	btdev->commands[25] |= 0x04;	/* LE Read Local Features */
> +	btdev->commands[25] |= 0x10;	/* LE Set Random Address */
>  	btdev->commands[25] |= 0x20;	/* LE Set Adv Parameters */
>  	btdev->commands[25] |= 0x40;	/* LE Read Adv TX Power */
>  	btdev->commands[25] |= 0x80;	/* LE Set Adv Data */
> +	btdev->commands[26] |= 0x01;	/* LE Set Scan Response Data */
>  	btdev->commands[26] |= 0x02;	/* LE Set Adv Enable */
>  	btdev->commands[26] |= 0x04;	/* LE Set Scan Parameters */
>  	btdev->commands[26] |= 0x08;	/* LE Set Scan Enable */
> +	btdev->commands[26] |= 0x10;	/* LE Create Connection */
>  	btdev->commands[26] |= 0x40;	/* LE Read White List Size */
> +	btdev->commands[26] |= 0x80;	/* LE Clear White List */
> +	btdev->commands[27] |= 0x04;	/* LE Connection Update */
> +	btdev->commands[27] |= 0x20;	/* LE Read Remote Used Features */
>  	btdev->commands[27] |= 0x40;	/* LE Encrypt */
>  	btdev->commands[27] |= 0x80;	/* LE Rand */
> +	btdev->commands[28] |= 0x01;	/* LE Start Encryption */
> +	btdev->commands[28] |= 0x02;	/* LE Long Term Key Request Reply */
> +	btdev->commands[28] |= 0x04;	/* LE Long Term Key Request Neg Reply */
>  	btdev->commands[28] |= 0x08;	/* LE Read Supported States */
>  	btdev->commands[28] |= 0x10;	/* LE Receiver Test */
>  	btdev->commands[28] |= 0x20;	/* LE Transmitter Test */

I'm surprised these were missing. Good catch! I've applied this patch,
so no need to resend it for your future revisions of this set.

Johan

  reply	other threads:[~2015-08-29  3:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 15:54 [PATCH 1/5] emulator: Fix LE Connection Complete Event data Mariusz Skamra
2015-08-27 15:54 ` [PATCH 2/5] emulator: Update LE supported commands Mariusz Skamra
2015-08-29  3:25   ` Johan Hedberg [this message]
2015-08-27 15:54 ` [PATCH 3/5] emulator: Remove duplicated assignment Mariusz Skamra
2015-08-27 15:54 ` [PATCH 4/5] emulator: Add support for LE Remote Connection Parameter Request Reply Mariusz Skamra
2015-08-27 15:54 ` [PATCH 5/5] emulator: Enable Slave-initiated Features Exchange feature Mariusz Skamra
2015-08-29  3:20 ` [PATCH 1/5] emulator: Fix LE Connection Complete Event data Johan Hedberg
2015-08-31 10:09   ` [PATCHv2 1/5] emulator: Remove duplicated assignment Mariusz Skamra
2015-08-31 10:09   ` [PATCHv2 2/5] emulator: Add support for LE Remote Connection Parameter Request Reply Mariusz Skamra
2015-08-31 10:09   ` [PATCHv2 3/5] emulator: Add support for LE Remote Connection Parameter Request Negative Reply Mariusz Skamra
2015-08-31 10:09   ` [PATCHv2 4/5] emulator: Enable Slave-initiated Features Exchange feature Mariusz Skamra
2015-08-31 10:09   ` [PATCHv2 5/5] emulator: Refactor le set scan enable command handler Mariusz Skamra
2015-08-31 10:18   ` [PATCHv2 1/6] emulator: Fix LE Connection Complete Event data Mariusz Skamra
2015-08-31 10:18   ` [PATCHv2 2/6] emulator: Remove duplicated assignment Mariusz Skamra
2015-08-31 10:18   ` [PATCHv2 3/6] emulator: Add support for LE Remote Connection Parameter Request Reply Mariusz Skamra
2015-08-31 10:18   ` [PATCHv2 4/6] emulator: Add support for LE Remote Connection Parameter Request Negative Reply Mariusz Skamra
2015-08-31 10:18   ` [PATCHv2 5/6] emulator: Enable Slave-initiated Features Exchange feature Mariusz Skamra
2015-08-31 10:18   ` [PATCHv2 6/6] emulator: Refactor le set scan enable command handler Mariusz Skamra
  -- strict thread matches above, loose matches on Subject: below --
2015-08-31 10:09 [PATCH] emulator: Improve " Mariusz Skamra
2015-08-31 10:13 ` Mariusz Skamra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150829032522.GB8367@t440s \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mariusz.skamra@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).