From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jakub Pawlowski <jpawlowski@google.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 1/2] gdbus: add method for immediate property update
Date: Fri, 18 Sep 2015 11:02:41 +0300 [thread overview]
Message-ID: <20150918080241.GA368@t440s.lan> (raw)
In-Reply-To: <1442562403-5176-1-git-send-email-jpawlowski@google.com>
Hi Jakub,
On Fri, Sep 18, 2015, Jakub Pawlowski wrote:
> +void g_dbus_emit_property_changed_full(DBusConnection *connection,
> + const char *path, const char *interface,
> + const char *name, gboolean flush);
I can't say I'm a fan of boolean parameters like this where it's
essentially impossible to say when looking at the calling code what the
parameter does (in this case the completely generic "full" in the
function name doesn't even give any hints about what exactly the
parameter might be). Instead, using a flags parameter + enum would be
one way to keep the calling code understandable.
Johan
prev parent reply other threads:[~2015-09-18 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 7:46 [PATCH v3 1/2] gdbus: add method for immediate property update Jakub Pawlowski
2015-09-18 7:46 ` [PATCH v3 2/2] core/gatt-client: fix losing notifications Jakub Pawlowski
2015-09-18 8:02 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918080241.GA368@t440s.lan \
--to=johan.hedberg@gmail.com \
--cc=jpawlowski@google.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).