* [PATCHv2] Bluetooth:hci_qca: Changed unsigned long to bool
@ 2015-09-28 8:03 Mutharaju, Prasanna (P.)
2015-09-28 11:07 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Mutharaju, Prasanna (P.) @ 2015-09-28 8:03 UTC (permalink / raw)
To: marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com,
ext.szymon.janc@tieto.com
Cc: linux-bluetooth@vger.kernel.org
From: Prasanna Karthik <mkarthi3@visteon.com>
'retransmit' being set in HCI_IBS_TX_WAKING case, using bool would be
efficient. Initialize local bool to false.
Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
---
drivers/bluetooth/hci_qca.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index a8aa077..6fbd7d8 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -347,7 +347,7 @@ static void hci_ibs_wake_retrans_timeout(unsigned long =
arg)
struct hci_uart *hu =3D (struct hci_uart *)arg;
struct qca_data *qca =3D hu->priv;
unsigned long flags, retrans_delay;
- unsigned long retransmit =3D 0;
+ bool retransmit =3D false;
=20
BT_DBG("hu %p wake retransmit timeout in %d state",
hu, qca->tx_ibs_state);
@@ -358,7 +358,7 @@ static void hci_ibs_wake_retrans_timeout(unsigned long =
arg)
switch (qca->tx_ibs_state) {
case HCI_IBS_TX_WAKING:
/* No WAKE_ACK, retransmit WAKE */
- retransmit =3D 1;
+ retransmit =3D true;
if (send_hci_ibs_cmd(HCI_IBS_WAKE_IND, hu) < 0) {
BT_ERR("Failed to acknowledge device wake up");
break;
--=20
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2] Bluetooth:hci_qca: Changed unsigned long to bool
2015-09-28 8:03 [PATCHv2] Bluetooth:hci_qca: Changed unsigned long to bool Mutharaju, Prasanna (P.)
@ 2015-09-28 11:07 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2015-09-28 11:07 UTC (permalink / raw)
To: Mutharaju, Prasanna (P.)
Cc: Gustavo F. Padovan, Johan Hedberg, ext.szymon.janc@tieto.com,
linux-bluetooth@vger.kernel.org
Hi Prasanna,
> 'retransmit' being set in HCI_IBS_TX_WAKING case, using bool would be
> efficient. Initialize local bool to false.
>
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
> ---
> drivers/bluetooth/hci_qca.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-28 11:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-28 8:03 [PATCHv2] Bluetooth:hci_qca: Changed unsigned long to bool Mutharaju, Prasanna (P.)
2015-09-28 11:07 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).