* [PATCH] bluetooth: bt3c_cs: clean up bt3c_cs driver code
@ 2015-10-01 12:56 Mutharaju, Prasanna (P.)
2015-10-01 13:23 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Mutharaju, Prasanna (P.) @ 2015-10-01 12:56 UTC (permalink / raw)
To: marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
From: Prasanna Karthik <mkarthi3@visteon.com>
Patch fixes the checkpatch warnings:
- use linux/io.h instead of asm/io.h
- NULL comparison could be re-written
Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
---
drivers/bluetooth/bt3c_cs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/bt3c_cs.c b/drivers/bluetooth/bt3c_cs.c
index 772a277..5597eef 100644
--- a/drivers/bluetooth/bt3c_cs.c
+++ b/drivers/bluetooth/bt3c_cs.c
@@ -39,7 +39,7 @@
#include <linux/serial.h>
#include <linux/serial_reg.h>
#include <linux/bitops.h>
-#include <asm/io.h>
+#include <linux/io.h>
=20
#include <linux/device.h>
#include <linux/firmware.h>
@@ -233,7 +233,7 @@ static void bt3c_receive(struct bt3c_info *info)
info->hdev->stat.byte_rx++;
=20
/* Allocate packet */
- if (info->rx_skb =3D=3D NULL) {
+ if (!info->rx_skb) {
info->rx_state =3D RECV_WAIT_PACKET_TYPE;
info->rx_count =3D 0;
info->rx_skb =3D bt_skb_alloc(HCI_MAX_FRAME_SIZE, GFP_ATOMIC);
--=20
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bluetooth: bt3c_cs: clean up bt3c_cs driver code
2015-10-01 12:56 [PATCH] bluetooth: bt3c_cs: clean up bt3c_cs driver code Mutharaju, Prasanna (P.)
@ 2015-10-01 13:23 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2015-10-01 13:23 UTC (permalink / raw)
To: Mutharaju, Prasanna (P.)
Cc: Gustavo F. Padovan, Johan Hedberg,
linux-bluetooth@vger.kernel.org
Hi Prasanna,
> Patch fixes the checkpatch warnings:
> - use linux/io.h instead of asm/io.h
> - NULL comparison could be re-written
>
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
> ---
> drivers/bluetooth/bt3c_cs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
the patch does not apply to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-01 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-01 12:56 [PATCH] bluetooth: bt3c_cs: clean up bt3c_cs driver code Mutharaju, Prasanna (P.)
2015-10-01 13:23 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).