From: Dan Carpenter <dan.carpenter@oracle.com>
To: marcel@holtmann.org
Cc: linux-bluetooth@vger.kernel.org
Subject: re: Bluetooth: btbcm: Read the local name in setup stage
Date: Tue, 6 Oct 2015 21:57:05 +0300 [thread overview]
Message-ID: <20151006185705.GA9369@mwanda> (raw)
Hello Marcel Holtmann,
The patch 8af9da1ab784: "Bluetooth: btbcm: Read the local name in
setup stage" from Oct 5, 2015, leads to the following static checker
warning:
drivers/bluetooth/btbcm.c:533 btbcm_setup_apple()
error: 'skb' dereferencing possible ERR_PTR()
drivers/bluetooth/btbcm.c
522 /* Read Verbose Config Version Info */
523 skb = btbcm_read_verbose_config(hdev);
524 if (!IS_ERR(skb)) {
525 BT_INFO("%s: BCM: chip id %u build %4.4u", hdev->name,
526 skb->data[1], get_unaligned_le16(skb->data + 5));
527 kfree_skb(skb);
528 }
529
530 /* Read Local Name */
531 skb = btbcm_read_local_name(hdev);
532 if (IS_ERR(skb)) {
This test is reversed?
533 BT_INFO("%s: %s", hdev->name, (char *)(skb->data + 1));
534 kfree_skb(skb);
535 }
regards,
dan carpenter
next reply other threads:[~2015-10-06 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 18:57 Dan Carpenter [this message]
2015-10-07 4:45 ` Bluetooth: btbcm: Read the local name in setup stage Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006185705.GA9369@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox