Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Lukasz Duda <lukasz.duda@nordicsemi.no>
Cc: alex.aring@gmail.com, linux-bluetooth@vger.kernel.org,
	glenn.ruben.bakke@nordicsemi.no
Subject: Re: [PATCH] Bluetooth: 6lowpan: Fix handling of uncompressed IPv6 packets
Date: Sat, 23 Jan 2016 12:27:07 +0000	[thread overview]
Message-ID: <20160123122707.GB16166@t440s> (raw)
In-Reply-To: <1452700668-4241-1-git-send-email-lukasz.duda@nordicsemi.no>

Hi Lukasz,

On Wed, Jan 13, 2016, Lukasz Duda wrote:
> This patch fixes incorrect handling of the 6lowpan packets that contain
> uncompressed IPv6 header.
> 
> RFC4944 specifies a special dispatch for 6lowpan to carry uncompressed
> IPv6 header. This dispatch (1 byte long) has to be removed during
> reception and skb data pointer has to be moved. To correctly point in
> the beginning of the IPv6 header the dispatch byte has to be pulled off
> before packet can be processed by netif_rx_in().
> 
> Test scenario: IPv6 packets are not correctly interpreted by the network
> layer when IPv6 header is not compressed (e.g. ICMPv6 Echo Reply is not
> propagated correctly to the ICMPv6 layer because the extra byte will make
> the header look corrupted).
> 
> Similar approach is done for IEEE 802.15.4.
> 
> Signed-off-by: Lukasz Duda <lukasz.duda@nordicsemi.no>
> Signed-off-by: Glenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>
> ---
>  net/bluetooth/6lowpan.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied to bluetooth.git. Thanks.

Johan

      parent reply	other threads:[~2016-01-23 12:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 15:57 [PATCH] Bluetooth: 6lowpan: Fix handling of uncompressed IPv6 packets Lukasz Duda
2016-01-14 10:30 ` Jukka Rissanen
2016-01-23 12:27 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160123122707.GB16166@t440s \
    --to=johan.hedberg@gmail.com \
    --cc=alex.aring@gmail.com \
    --cc=glenn.ruben.bakke@nordicsemi.no \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=lukasz.duda@nordicsemi.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox