From: Alexander Aring <alex.aring@gmail.com>
To: Patrik Flykt <patrik.flykt@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 1/5] bluetooth: Merge Bluetooth 6lowpan functionality to bluetooth module
Date: Sat, 5 Mar 2016 22:15:52 +0100 [thread overview]
Message-ID: <20160305211551.GA8911@omega> (raw)
In-Reply-To: <20160305210644.GA1853@omega>
On Sat, Mar 05, 2016 at 10:06:44PM +0100, Alexander Aring wrote:
> Hi,
>
> tried that patch out and it fails:
>
> net/bluetooth/af_bluetooth.c:32:35: fatal error:
> net/bluetooth/6lowpan.h: No such file or directory #include <net/bluetooth/6lowpan.h>
>
> There is some missing file. :-)
>
> Actually while review I tried to find the prototypes for init/exit
> functionality. So this file is missing somehow but I think it should include:
>
> #ifdef CONFIG_BT_6LOWPAN
> ... prototypes ...
> #else
> static inline empty files of prototypes
s/files/functions/
Also if the above is true to put the prototypes there, why putting it
into a "global" header file. Use some local header #include "6lowpan.h"
or something else. :-)
Maybe I oversight something here and there are good arguments to put it
into a global header.
- Alex
next prev parent reply other threads:[~2016-03-05 21:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 11:40 [RFC 0/5] Implement BTLE Network Management interface API Patrik Flykt
2016-03-04 11:40 ` [RFC 1/5] bluetooth: Merge Bluetooth 6lowpan functionality to bluetooth module Patrik Flykt
2016-03-05 21:06 ` Alexander Aring
2016-03-05 21:15 ` Alexander Aring [this message]
2016-03-04 11:40 ` [RFC 2/5] bluetooth: Implement Get Networks Management API command Patrik Flykt
2016-03-04 14:16 ` Patrik Flykt
2016-03-04 11:40 ` [RFC 3/5] l2cap: Pass hci_dev to l2cap_chan_connect() Patrik Flykt
2016-03-04 17:29 ` Marcel Holtmann
2016-03-04 11:40 ` [RFC 4/5] bluetooth: Implement Add Network Management API command Patrik Flykt
2016-03-04 11:40 ` [RFC 5/5] bluetooth: Implement Remove " Patrik Flykt
2016-03-04 17:30 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305211551.GA8911@omega \
--to=alex.aring@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=patrik.flykt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox