From: Rob Herring <robh@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcel Holtmann <marcel@holtmann.org>,
Jiri Slaby <jslaby@suse.com>, Sebastian Reichel <sre@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Peter Hurley <peter@hurleysoftware.com>,
NeilBrown <neil@brown.name>,
"Dr . H . Nikolaus Schaller" <hns@goldelico.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-bluetooth@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 3/3] tty: serial_core: add uart controller registration
Date: Wed, 17 Aug 2016 20:14:45 -0500 [thread overview]
Message-ID: <20160818011445.22726-4-robh@kernel.org> (raw)
In-Reply-To: <20160818011445.22726-1-robh@kernel.org>
Register serial ports with the uart device core as a controller and add
a receive handler call.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/tty/serial/serial_core.c | 8 ++++++++
include/linux/serial_core.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 9dd444f..1552fee 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -34,6 +34,7 @@
#include <linux/serial_core.h>
#include <linux/delay.h>
#include <linux/mutex.h>
+#include <linux/uart_device.h>
#include <asm/irq.h>
#include <asm/uaccess.h>
@@ -2800,6 +2801,10 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
uart_configure_port(drv, state, uport);
+ uport->ctrlr = uart_controller_alloc(uport->dev, 0);
+ uport->ctrlr->port = uport;
+ uart_controller_add(uport->ctrlr);
+
num_groups = 2;
if (uport->attr_group)
num_groups++;
@@ -3027,6 +3032,9 @@ void uart_insert_char(struct uart_port *port, unsigned int status,
{
struct tty_port *tport = &port->state->port;
+ if (uart_controller_rx(port->ctrlr, ch) >= 0)
+ return;
+
if ((status & port->ignore_status_mask & ~overrun) == 0)
if (tty_insert_flip_char(tport, ch, flag) == 0)
++port->icount.buf_overrun;
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index a27ca1f..7cde6a9 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -155,6 +155,7 @@ struct uart_port {
unsigned int read_status_mask; /* driver specific */
unsigned int ignore_status_mask; /* driver specific */
+ struct uart_controller *ctrlr;
struct uart_state *state; /* pointer to parent state */
struct uart_icount icount; /* statistics */
--
2.9.2
next prev parent reply other threads:[~2016-08-18 1:14 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 1:14 [RFC PATCH 0/3] UART slave device bus Rob Herring
2016-08-18 1:14 ` [RFC PATCH 1/3] uart bus: Introduce new bus for UART slave devices Rob Herring
2016-08-18 1:14 ` [RFC PATCH 2/3] tty: serial_core: make tty_struct optional Rob Herring
2016-08-18 10:50 ` Pavel Machek
2016-08-18 1:14 ` Rob Herring [this message]
2016-08-18 10:22 ` [RFC PATCH 0/3] UART slave device bus Greg Kroah-Hartman
2016-08-18 10:30 ` Marcel Holtmann
2016-08-18 10:53 ` Greg Kroah-Hartman
2016-08-18 13:53 ` Rob Herring
2016-08-18 13:15 ` Rob Herring
2016-08-18 15:04 ` One Thousand Gnomes
2016-08-18 18:33 ` Rob Herring
2016-08-19 11:03 ` One Thousand Gnomes
2016-08-25 16:40 ` Rob Herring
2016-08-26 13:12 ` One Thousand Gnomes
2016-08-18 10:39 ` H. Nikolaus Schaller
2016-08-18 10:47 ` Pavel Machek
2016-08-18 10:54 ` H. Nikolaus Schaller
2016-08-18 10:57 ` Greg Kroah-Hartman
2016-08-18 11:14 ` H. Nikolaus Schaller
2016-08-18 14:40 ` One Thousand Gnomes
2016-08-18 14:58 ` Greg Kroah-Hartman
2016-08-18 11:27 ` H. Nikolaus Schaller
2016-08-18 10:49 ` Marcel Holtmann
2016-08-18 10:55 ` Greg Kroah-Hartman
2016-08-18 11:01 ` Marcel Holtmann
2016-08-18 11:24 ` Greg Kroah-Hartman
2016-08-18 11:42 ` Pavel Machek
2016-08-18 11:51 ` Marcel Holtmann
2016-08-18 15:14 ` One Thousand Gnomes
2016-08-18 15:13 ` One Thousand Gnomes
2016-08-18 11:10 ` Pavel Machek
2016-08-18 11:18 ` H. Nikolaus Schaller
2016-08-18 11:49 ` Marcel Holtmann
2016-08-18 12:16 ` H. Nikolaus Schaller
2016-08-18 15:15 ` One Thousand Gnomes
2016-08-18 11:47 ` Marcel Holtmann
2016-08-18 13:01 ` Pavel Machek
2016-08-18 15:16 ` One Thousand Gnomes
2016-08-18 11:02 ` H. Nikolaus Schaller
2016-08-18 11:41 ` Marcel Holtmann
2016-08-18 12:07 ` H. Nikolaus Schaller
2016-08-18 11:02 ` Pavel Machek
2016-08-18 13:07 ` Linus Walleij
2016-08-18 17:31 ` Marcel Holtmann
2016-08-18 14:25 ` One Thousand Gnomes
2016-08-18 15:14 ` H. Nikolaus Schaller
2016-08-18 15:38 ` One Thousand Gnomes
2016-08-18 18:31 ` H. Nikolaus Schaller
2016-08-18 22:25 ` Rob Herring
2016-08-19 11:38 ` One Thousand Gnomes
2016-08-19 15:36 ` Sebastian Reichel
2016-08-18 20:29 ` Sebastian Reichel
2016-08-18 23:08 ` Rob Herring
2016-08-19 5:21 ` Sebastian Reichel
2016-08-19 7:29 ` H. Nikolaus Schaller
2016-08-19 7:49 ` Oleksij Rempel
2016-08-19 17:50 ` H. Nikolaus Schaller
2016-08-19 20:19 ` Oleksij Rempel
2016-08-20 13:34 ` One Thousand Gnomes
2016-08-21 7:50 ` H. Nikolaus Schaller
2016-08-22 20:39 ` Sebastian Reichel
2016-08-22 21:23 ` H. Nikolaus Schaller
2016-08-22 21:43 ` Arnd Bergmann
2016-08-22 22:42 ` Sebastian Reichel
2016-08-22 22:52 ` One Thousand Gnomes
2016-08-22 23:10 ` Sebastian Reichel
2016-08-23 7:28 ` H. Nikolaus Schaller
2016-08-27 12:01 ` Michal Suchanek
2016-08-19 11:06 ` One Thousand Gnomes
2016-08-19 17:42 ` H. Nikolaus Schaller
2016-08-20 13:22 ` One Thousand Gnomes
2016-08-21 7:50 ` H. Nikolaus Schaller
2016-08-21 17:09 ` One Thousand Gnomes
2016-08-21 18:23 ` H. Nikolaus Schaller
2016-08-22 9:09 ` One Thousand Gnomes
2016-08-22 9:33 ` Marcel Holtmann
2016-08-19 11:03 ` One Thousand Gnomes
2016-08-19 14:44 ` Sebastian Reichel
2016-08-22 12:37 ` Arnd Bergmann
2016-08-22 13:38 ` Rob Herring
2016-08-22 15:24 ` Arnd Bergmann
2016-08-22 15:28 ` Marcel Holtmann
2016-08-22 15:46 ` Arnd Bergmann
2016-08-22 15:45 ` One Thousand Gnomes
2016-08-22 21:07 ` Marcel Holtmann
2016-08-22 21:35 ` One Thousand Gnomes
2016-08-22 22:03 ` Sebastian Reichel
2016-08-22 22:46 ` One Thousand Gnomes
2016-08-22 23:41 ` Sebastian Reichel
2016-08-24 12:14 ` Linus Walleij
2016-08-22 16:44 ` Rob Herring
2016-08-22 17:02 ` One Thousand Gnomes
2016-08-22 17:30 ` Rob Herring
2016-08-22 17:38 ` One Thousand Gnomes
2016-08-22 21:16 ` Marcel Holtmann
2016-08-22 21:32 ` One Thousand Gnomes
2016-08-22 22:00 ` Pavel Machek
2016-08-22 22:54 ` One Thousand Gnomes
2016-08-22 23:57 ` Sebastian Reichel
2016-08-23 0:15 ` One Thousand Gnomes
2016-08-23 0:57 ` Sebastian Reichel
2016-08-24 13:57 ` One Thousand Gnomes
2016-08-24 14:29 ` Marcel Holtmann
2016-08-23 11:42 ` Marcel Holtmann
2016-08-22 23:02 ` Sebastian Reichel
2016-08-22 20:00 ` Sebastian Reichel
2016-08-22 22:00 ` Rob Herring
2016-08-22 22:18 ` Sebastian Reichel
2016-08-23 21:04 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818011445.22726-4-robh@kernel.org \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=jslaby@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=neil@brown.name \
--cc=pavel@ucw.cz \
--cc=peter@hurleysoftware.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).