linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: luiz.von.dentz@intel.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Commit 375d02473fb prevents obexd from accepting profile connections
Date: Tue, 25 Oct 2016 12:04:36 -0400	[thread overview]
Message-ID: <20161025160436.GB35881@redhat.com> (raw)

Hi Luiz,

I was testing 5.42 with my OBEX testsuite and noticed it stopped working due
to the following commit:

commit 375d02473fb7f8b90e39bc79001ab6f97a81bd3b
Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Date:   Mon Aug 8 13:33:35 2016 +0300

    core/service: Fix setting connecting state

    If the profile don't implement .accept callback it means it cannot
    connect in this mode, which is normally used for GATT profiles, so the
    code shall not assume the service will start connecting and instead just
    return an error.

diff --git a/src/service.c b/src/service.c
index 0da14ab..f387fc4 100644
--- a/src/service.c
+++ b/src/service.c
@@ -197,7 +197,7 @@ int service_accept(struct btd_service *service)
        }

        if (!service->profile->accept)
-               goto done;
+               return -ENOSYS;

        err = service->profile->accept(service);
        if (!err)


It seems all the OBEX profiles lack an .accept function and therefore get
rejected now?

Unless my test environment is misconfigured.  Basically, I have two machines
next to each other, one runs a python script to register an authorization
agent and obex agent and then sits there waiting for remote connections.
The other machine tries to walk through the various obex apis to connect
with the server and exchange data.

Any setup of an obex connection with the server is terminated and my tests
fail.  Thoughts?

Cheers,
Don


             reply	other threads:[~2016-10-25 16:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 16:04 Don Zickus [this message]
2016-10-25 16:08 ` Commit 375d02473fb prevents obexd from accepting profile connections Luiz Augusto von Dentz
2016-10-25 16:26   ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161025160436.GB35881@redhat.com \
    --to=dzickus@redhat.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.von.dentz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).