From: Sebastian Reichel <sre@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcel Holtmann <marcel@holtmann.org>,
Jiri Slaby <jslaby@suse.com>, Arnd Bergmann <arnd@arndb.de>,
"Dr . H . Nikolaus Schaller" <hns@goldelico.com>,
Peter Hurley <peter@hurleysoftware.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Loic Poulain <loic.poulain@intel.com>,
Pavel Machek <pavel@ucw.cz>, NeilBrown <neil@brown.name>,
Linus Walleij <linus.walleij@linaro.org>,
linux-bluetooth@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] serdev: Introduce new bus for serial attached devices
Date: Tue, 31 Jan 2017 15:31:43 +0100 [thread overview]
Message-ID: <20170131143143.tvf4w7itfwqmweq4@earth> (raw)
In-Reply-To: <20170125202343.30923-4-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
Hi Rob,
On Wed, Jan 25, 2017 at 02:23:41PM -0600, Rob Herring wrote:
> diff --git a/include/linux/serdev.h b/include/linux/serdev.h
> new file mode 100644
> index 000000000000..4f8f76d02ca8
> --- /dev/null
> +++ b/include/linux/serdev.h
>
> [...]
>
> +#ifdef CONFIG_SERIAL_DEV_BUS
>
> [method definitions]
>
> #else
>
> [method stubs]
>
> #endif
>
> [...]
This should also test for SERIAL_DEV_BUS=m, so use
#if IS_ENABLED(CONFIG_SERIAL_DEV_BUS)
(This was found by the kbuild test robot)
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-01-31 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 20:23 [PATCH v3 0/5] Serial slave device bus Rob Herring
2017-01-25 20:23 ` [PATCH v3 1/5] tty_port: Add port client functions Rob Herring
2017-01-25 20:23 ` [PATCH v3 2/5] dt/bindings: Add a serial/UART attached device binding Rob Herring
2017-01-25 20:23 ` [PATCH v3 3/5] serdev: Introduce new bus for serial attached devices Rob Herring
2017-01-31 14:31 ` Sebastian Reichel [this message]
2017-01-25 20:23 ` [PATCH v3 4/5] serdev: add a tty port controller driver Rob Herring
2017-01-25 20:23 ` [PATCH v3 5/5] tty_port: register tty ports with serdev bus Rob Herring
2017-01-31 3:02 ` [PATCH v3 0/5] Serial slave device bus Sebastian Reichel
2017-01-31 5:44 ` Sebastian Reichel
2017-01-31 15:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131143143.tvf4w7itfwqmweq4@earth \
--to=sre@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=jslaby@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=loic.poulain@intel.com \
--cc=marcel@holtmann.org \
--cc=neil@brown.name \
--cc=pavel@ucw.cz \
--cc=peter@hurleysoftware.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox