From: Konrad Zapalowicz <konrad.zapalowicz@canonical.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: marcel@holtmann.org, luiz.von.dentz@intel.com,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] core: replace sizeof(filename) with PATH_MAX
Date: Fri, 31 Mar 2017 13:32:18 +0200 [thread overview]
Message-ID: <20170331113218.GA28779@annapurna> (raw)
In-Reply-To: <1490959289.13868.12.camel@hadess.net>
On 03/31, Bastien Nocera wrote:
> On Fri, 2017-03-31 at 13:03 +0200, Konrad Zapalowicz wrote:
> > From: Konrad Zapałowicz <konrad.zapalowicz@canonical.com>
> >
> > This commit replaces sizeof(filename) with PATH_MAX to match the
> > common
> > scheme which is used in other places.
>
> I wonder why g_strdup_printf() isn't used instead. Would allow ignoring
> PATH_MAX.
I guess it is because it is easier. With g_strdup_printf() one would
have to take care about freeing memory. This is not a case with having
filename as an atomatic variable.
next prev parent reply other threads:[~2017-03-31 11:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 11:03 [PATCH] core: replace sizeof(filename) with PATH_MAX Konrad Zapalowicz
2017-03-31 11:21 ` Bastien Nocera
2017-03-31 11:32 ` Konrad Zapalowicz [this message]
2017-03-31 14:00 ` Von Dentz, Luiz
2017-03-31 14:15 ` Konrad Zapalowicz
2017-03-31 14:44 ` [PATCH v2] " Konrad Zapalowicz
2017-04-03 11:08 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331113218.GA28779@annapurna \
--to=konrad.zapalowicz@canonical.com \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox