Re: [PATCH 3/3] bluetooth: hci_ll: Use new hci_uart_unregister_device() function.

[Sebastian Reichel <sebastian.reichel@collabora.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

Hi,

On Sat, Jul 08, 2017 at 05:37:43PM +0100, Ian Molton wrote:
> Convert hci_ll to use hci_uart_unregister_device().
> 
> This simplifies the _remove() handler as well as fixes a
> potential race condition on unload.
> 
> Signed-off-by: Ian Molton <ian@mnementh.co.uk>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabor.co.uk>

-- Sebastian

> ---
>  drivers/bluetooth/hci_ll.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
> index c982943f0747..1b898445a0b8 100644
> --- a/drivers/bluetooth/hci_ll.c
> +++ b/drivers/bluetooth/hci_ll.c
> @@ -742,14 +742,8 @@ static int hci_ti_probe(struct serdev_device *serdev)
>  static void hci_ti_remove(struct serdev_device *serdev)
>  {
>  	struct ll_device *lldev = serdev_device_get_drvdata(serdev);
> -	struct hci_uart *hu = &lldev->hu;
> -	struct hci_dev *hdev = hu->hdev;
>  
> -	cancel_work_sync(&hu->write_work);
> -
> -	hci_unregister_dev(hdev);
> -	hci_free_dev(hdev);
> -	hu->proto->close(hu);
> +	hci_uart_unregister_device(&lldev->hu);
>  }
>  
>  static const struct of_device_id hci_ti_of_match[] = {
> -- 
> 2.11.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]