Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

Marcel Holtmann
2017-07-24T17:10:14Z

Hi Sebastian,

>>>>>>> The Nokia devices require the setup of its Public Bluetooth Device
>>>>>>> Address and for that it is required to depend on vendor specific
>>>>>>> commands. For Broadcom based Nokia devices, that is part of btbcm
>>>>>>> module and can be selected via BT_BCM config option.
>>>>>>>
>>>>>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>>>>>>
>>>>>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>>>>>
>>>>> btw. we need to also provide the set_bdaddr for TI chips.
>>>>
>>>> The TI based chip in Nokia N950 has a proper address configured, so
>>>> it works without set_bdaddr (it would still be nice of course). It
>>>> also seems to be missing for hci_ll, though. So the required command
>>>> is completly unknown?
>>>
>>> are these a TI address or a Nokia address? I doubt Nokia would
>>> have actually shipped any hardware using an IEEE assigned address
>>> to TI.
>>
>> I can check this later.
>
> The BD address on my N950 starts with B4:EE:D4, which belongs
> to TI as far as I can see. Note, that N950 is a developer only
> device.

as long as not every N950 now has the same address. But I think if Nokia would have shipped the device then it would have had to be a Nokia address.

Regards

Marcel