From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_bcm: Use operation speed of 4Mbps only for ACPI devices
Date: Wed, 16 Aug 2017 18:02:38 +0300 [thread overview]
Message-ID: <20170816150238.GA1577@x1c.home> (raw)
In-Reply-To: <20170816075330.45923-1-marcel@holtmann.org>
Hi Marcel,
On Wed, Aug 16, 2017, Marcel Holtmann wrote:
> Not all Broadcom controller support the 4Mbps operational speed on UART
> devices. This is because the UART clock setting changes might not be
> supported.
>
> < HCI Command: Broadcom Write UART Clock Setting (0x3f|0x0045) plen 1
> 01 .
> > HCI Event: Command Complete (0x0e) plen 4
> Broadcom Write UART Clock Setting (0x3f|0x0045) ncmd 1
> Status: Unknown HCI Command (0x01)
>
> To support any operational speed higher than 3Mbps, support for this
> command is required. With that respect it is better to not enforce any
> operational speed by default. Only when its support is known, then allow
> for higher operational speed.
>
> This patch assigns the 4Mbps opertional speed only for devices
> discovered through ACPI and leave all others at the default 115200.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> drivers/bluetooth/hci_bcm.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Applied to bluetooth-next. Thanks.
Johan
prev parent reply other threads:[~2017-08-16 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 7:53 [PATCH] Bluetooth: hci_bcm: Use operation speed of 4Mbps only for ACPI devices Marcel Holtmann
2017-08-16 15:02 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816150238.GA1577@x1c.home \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox