linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: linux-bluetooth@vger.kernel.org
Cc: Bastien Nocera <hadess@hadess.net>
Subject: [PATCH 2/2] hostname: Fix "BlueZ 5.XX" adapter name on startup
Date: Wed, 20 Sep 2017 14:54:45 +0200	[thread overview]
Message-ID: <20170920125445.24792-2-hadess@hadess.net> (raw)
In-Reply-To: <20170920125445.24792-1-hadess@hadess.net>

The hostname plugin listens to property changes from systemd-hostnamed
but doesn't fetch initial values. This means that unless the
PrettyHostname or StaticHostname changes, the default adapter will be
called "BlueZ 5.XX" matching the version number.

This is the case since the hostname plugin replaced the adaptername
plugin in 2012.

Fetch the initial values for PrettyHostname, StaticHostname and
Chassis when the plugin is initiated, so as to make the values
available for adapter setup.
---
 plugins/hostname.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/plugins/hostname.c b/plugins/hostname.c
index f876d0afb..db9187378 100644
--- a/plugins/hostname.c
+++ b/plugins/hostname.c
@@ -307,6 +307,10 @@ static int hostname_init(void)
 		hostname_proxy = NULL;
 		g_dbus_client_unref(hostname_client);
 		hostname_client = NULL;
+	} else {
+		g_dbus_proxy_refresh_property(hostname_proxy, "PrettyHostname");
+		g_dbus_proxy_refresh_property(hostname_proxy, "StaticHostname");
+		g_dbus_proxy_refresh_property(hostname_proxy, "Chassis");
 	}
 
 	return err;
-- 
2.14.1


  reply	other threads:[~2017-09-20 12:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20 12:54 [PATCH 1/2] hostname: Add more debug in soft failure cases Bastien Nocera
2017-09-20 12:54 ` Bastien Nocera [this message]
2017-09-20 15:48   ` [PATCH 2/2] hostname: Fix "BlueZ 5.XX" adapter name on startup Marcel Holtmann
2017-09-20 16:35     ` Bastien Nocera
2017-09-20 16:59       ` Marcel Holtmann
2017-09-20 18:57         ` Luiz Augusto von Dentz
2017-09-22 13:13           ` Bastien Nocera
2017-10-05 15:40             ` Bastien Nocera
2017-11-28  9:45             ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170920125445.24792-2-hadess@hadess.net \
    --to=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).