From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 3/3] avctp: Retry control PDU if timeout
Date: Thu, 26 Oct 2017 15:02:23 +0300 [thread overview]
Message-ID: <20171026120223.18492-3-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20171026120223.18492-1-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This attempts to resend a control PDU is not passthrough as the control
channel is considered unreliable packets may be lost.
---
profiles/audio/avctp.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
index 174f401d6..0d395814c 100644
--- a/profiles/audio/avctp.c
+++ b/profiles/audio/avctp.c
@@ -157,6 +157,7 @@ struct avctp_pending_req {
struct avctp_channel *chan;
uint8_t transaction;
guint timeout;
+ bool retry;
int err;
avctp_process_cb process;
void *data;
@@ -775,9 +776,16 @@ static gboolean req_timeout(gpointer user_data)
struct avctp_channel *chan = user_data;
struct avctp_pending_req *p = chan->p;
- DBG("transaction %u", p->transaction);
+ DBG("transaction %u retry %s", p->transaction, p->retry ? "true" :
+ "false");
p->timeout = 0;
+
+ if (p->retry) {
+ p->process(p->data);
+ return FALSE;
+ }
+
p->err = -ETIMEDOUT;
pending_destroy(p, NULL);
@@ -801,6 +809,9 @@ static int process_control(void *data)
if (ret < 0)
return ret;
+ if (req->op != AVC_OP_PASSTHROUGH)
+ p->retry = !p->retry;
+
p->timeout = g_timeout_add_seconds(CONTROL_TIMEOUT, req_timeout,
p->chan);
--
2.13.6
next prev parent reply other threads:[~2017-10-26 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 12:02 [PATCH BlueZ 1/3] avctp: Don't queue control request without callback Luiz Augusto von Dentz
2017-10-26 12:02 ` [PATCH BlueZ 2/3] avctp: Reintroduce a timeout for the browsing channel Luiz Augusto von Dentz
2017-10-26 12:02 ` Luiz Augusto von Dentz [this message]
2017-10-30 12:55 ` [PATCH BlueZ 1/3] avctp: Don't queue control request without callback Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026120223.18492-3-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).