From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 3/4] client: Fix format of arguments of set-service and set-manufacturer
Date: Sun, 26 Nov 2017 22:21:25 +0200 [thread overview]
Message-ID: <20171126202126.27783-3-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20171126202126.27783-1-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Optional arguments should contain only one set of '[' ']' otherwise
wordexp won't be able to parse it.
---
client/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/client/main.c b/client/main.c
index 38028c6c0..7661b33c0 100644
--- a/client/main.c
+++ b/client/main.c
@@ -2205,9 +2205,9 @@ static const struct bt_shell_menu advertise_menu = {
.entries = {
{ "set-uuids", "[uuid1 uuid2 ...]",
cmd_set_advertise_uuids, "Set advertise uuids" },
- { "set-service", "[uuid][data=[xx xx ...]", cmd_set_advertise_service,
+ { "set-service", "[uuid] [data=xx xx ...]", cmd_set_advertise_service,
"Set advertise service data" },
- { "set-manufacturer", "[id][data=[xx xx ...]",
+ { "set-manufacturer", "[id] [data=xx xx ...]",
cmd_set_advertise_manufacturer,
"Set advertise manufacturer data" },
{ "set-tx-power", "<on/off>", cmd_set_advertise_tx_power,
@@ -2254,7 +2254,7 @@ static const struct bt_shell_menu gatt_menu = {
{ "attribute-info", "[attribute/UUID]", cmd_attribute_info,
"Select attribute", attribute_generator },
{ "read", NULL, cmd_read, "Read attribute value" },
- { "write", "<data=[xx xx ...]>", cmd_write,
+ { "write", "<data=xx xx ...>", cmd_write,
"Write attribute value" },
{ "acquire-write", NULL, cmd_acquire_write,
"Acquire Write file descriptor" },
--
2.13.6
next prev parent reply other threads:[~2017-11-26 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 20:21 [PATCH BlueZ 1/4] shared/shell: Detect if the arguments are properly set Luiz Augusto von Dentz
2017-11-26 20:21 ` [PATCH BlueZ 2/4] client: Remove argument checks Luiz Augusto von Dentz
2017-11-26 20:21 ` Luiz Augusto von Dentz [this message]
2017-11-26 20:21 ` [PATCH BlueZ 4/4] shared/shell: Add default argument generator Luiz Augusto von Dentz
2017-11-27 4:17 ` ERAMOTO Masaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171126202126.27783-3-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).