linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jaganath Kanakkassery <jaganath.k.os@gmail.com>
Cc: linux-bluetooth@vger.kernel.org,
	Jaganath Kanakkassery <jaganathx.kanakkassery@intel.com>
Subject: Re: [PATCH 3/3 v2] doc/mgmt-api: Add advertising phys support to flags
Date: Mon, 27 Nov 2017 15:32:55 +0200	[thread overview]
Message-ID: <20171127133255.GA24336@x1c.home> (raw)
In-Reply-To: <1511173617-25442-4-git-send-email-jaganathx.kanakkassery@intel.com>

Hi Jaganath,

On Mon, Nov 20, 2017, Jaganath Kanakkassery wrote:
> @@ -2613,6 +2625,9 @@ Add Advertising Command
>  		4	Add TX Power field to Adv_Data
>  		5	Add Appearance field to Scan_Rsp
>  		6	Add Local Name in Scan_Rsp
> +		7	Secondary Channel with LE 1M
> +		8	Secondary Channel with LE 2M
> +		9	Secondary Channel with LE Coded
>  
>  	When the connectable flag is set, then the controller will use
>  	undirected connectable advertising. The value of the connectable
> @@ -2640,6 +2655,13 @@ Add Advertising Command
>  	supported to provide less air traffic for devices implementing
>  	broadcaster role.
>  
> +	Secondary channel flags can be used to advertise in secondary
> +	channel with the corresponding PHYs. In case of 2M, the primary
> +	channel used would be 1M. If none of them are set then secondary
> +	channel advertising would be disabled for this instance which is as
> +	good as legacy advertising. Combining the sets would result in
> +	multiple advertising sets being created.

What kind of combination of parameters would we select LE Coded for the
primary channel? Don't we need a flag for it? It should either way be
documented when LE Coded gets used for the primary PHY.

Johan

  reply	other threads:[~2017-11-27 13:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 10:26 [PATCH 0/3 v2] LE New PHYs kernel interfaces Jaganath Kanakkassery
2017-11-20 10:26 ` [PATCH 1/3 v2] doc/mgmt-api: Add support for Get PHY information command Jaganath Kanakkassery
2017-11-27 13:39   ` Johan Hedberg
2017-11-27 14:56     ` Jaganath K
2017-11-28  8:39   ` Marcel Holtmann
2017-11-20 10:26 ` [PATCH 2/3 v2] doc/mgmt-api: Add support for Set default Phy command Jaganath Kanakkassery
2017-11-28  8:56   ` Marcel Holtmann
2017-11-28 11:39     ` Jaganath K
2017-11-28 11:50       ` Marcel Holtmann
2017-11-20 10:26 ` [PATCH 3/3 v2] doc/mgmt-api: Add advertising phys support to flags Jaganath Kanakkassery
2017-11-27 13:32   ` Johan Hedberg [this message]
2017-11-27 14:42     ` Jaganath K
2017-11-28  7:43   ` Marcel Holtmann
2017-11-28  9:28     ` Jaganath K
2017-11-28 10:22       ` Marcel Holtmann
2017-11-27 10:51 ` [PATCH 0/3 v2] LE New PHYs kernel interfaces Jaganath K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127133255.GA24336@x1c.home \
    --to=johan.hedberg@gmail.com \
    --cc=jaganath.k.os@gmail.com \
    --cc=jaganathx.kanakkassery@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).