From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jaganath Kanakkassery <jaganath.k.os@gmail.com>
Cc: linux-bluetooth@vger.kernel.org,
Jaganath Kanakkassery <jaganathx.kanakkassery@intel.com>
Subject: Re: [PATCH 1/3 v2] doc/mgmt-api: Add support for Get PHY information command
Date: Mon, 27 Nov 2017 15:39:30 +0200 [thread overview]
Message-ID: <20171127133930.GB24336@x1c.home> (raw)
In-Reply-To: <1511173617-25442-2-git-send-email-jaganathx.kanakkassery@intel.com>
Hi Jaganath,
On Mon, Nov 20, 2017, Jaganath Kanakkassery wrote:
> +Get PHY Information Command
> +==========================
> +
> + Command Code: 0x0043
> + Controller Index: <controller id>
> + Command Parameters:
> + Return Parameters: Supported_phys (1 Octet)
> + Selected_phys (1 Octet)
Shouldn't the command have "Default" in its name, to be consistent with
your second patch? If it's not the default that this is returning, then
shouldn't there be a reference to which connection it applies to
(assuming this is intended to map to the HCI_LE_Set_PHY command)?
What about the PHY_options HCI parameter, where is that planned to be
specified?
Johan
next prev parent reply other threads:[~2017-11-27 13:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 10:26 [PATCH 0/3 v2] LE New PHYs kernel interfaces Jaganath Kanakkassery
2017-11-20 10:26 ` [PATCH 1/3 v2] doc/mgmt-api: Add support for Get PHY information command Jaganath Kanakkassery
2017-11-27 13:39 ` Johan Hedberg [this message]
2017-11-27 14:56 ` Jaganath K
2017-11-28 8:39 ` Marcel Holtmann
2017-11-20 10:26 ` [PATCH 2/3 v2] doc/mgmt-api: Add support for Set default Phy command Jaganath Kanakkassery
2017-11-28 8:56 ` Marcel Holtmann
2017-11-28 11:39 ` Jaganath K
2017-11-28 11:50 ` Marcel Holtmann
2017-11-20 10:26 ` [PATCH 3/3 v2] doc/mgmt-api: Add advertising phys support to flags Jaganath Kanakkassery
2017-11-27 13:32 ` Johan Hedberg
2017-11-27 14:42 ` Jaganath K
2017-11-28 7:43 ` Marcel Holtmann
2017-11-28 9:28 ` Jaganath K
2017-11-28 10:22 ` Marcel Holtmann
2017-11-27 10:51 ` [PATCH 0/3 v2] LE New PHYs kernel interfaces Jaganath K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127133930.GB24336@x1c.home \
--to=johan.hedberg@gmail.com \
--cc=jaganath.k.os@gmail.com \
--cc=jaganathx.kanakkassery@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).