From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 1/3] gatt: Make database_add_record detect the UUID
Date: Mon, 4 Dec 2017 10:10:52 -0200 [thread overview]
Message-ID: <20171204121054.29186-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
gatt_db_attribute does carry the UUID so this make database_add_record
add it directly instead of taking as parameter.
---
src/gatt-database.c | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/src/gatt-database.c b/src/gatt-database.c
index 3e10c901c..fa94a83f8 100644
--- a/src/gatt-database.c
+++ b/src/gatt-database.c
@@ -707,15 +707,30 @@ static sdp_record_t *record_new(uuid_t *uuid, uint16_t start, uint16_t end)
}
static uint32_t database_add_record(struct btd_gatt_database *database,
- uint16_t uuid,
struct gatt_db_attribute *attr,
const char *name)
{
sdp_record_t *record;
uint16_t start, end;
uuid_t svc, gap_uuid;
+ bt_uuid_t uuid;
+
+ gatt_db_attribute_get_service_uuid(attr, &uuid);
+
+ switch (uuid.type) {
+ case BT_UUID16:
+ sdp_uuid16_create(&svc, uuid.value.u16);
+ break;
+ case BT_UUID32:
+ sdp_uuid32_create(&svc, uuid.value.u32);
+ break;
+ case BT_UUID128:
+ sdp_uuid128_create(&svc, (void *) &uuid.value.u128);
+ break;
+ case BT_UUID_UNSPEC:
+ return 0;
+ }
- sdp_uuid16_create(&svc, uuid);
gatt_db_attribute_get_service_handles(attr, &start, &end);
record = record_new(&svc, start, end);
@@ -747,7 +762,7 @@ static void populate_gap_service(struct btd_gatt_database *database)
/* Add the GAP service */
bt_uuid16_create(&uuid, UUID_GAP);
service = gatt_db_add_service(database->db, &uuid, true, 5);
- database->gap_handle = database_add_record(database, UUID_GAP, service,
+ database->gap_handle = database_add_record(database, service,
"Generic Access Profile");
/*
@@ -902,8 +917,7 @@ static void populate_gatt_service(struct btd_gatt_database *database)
/* Add the GATT service */
bt_uuid16_create(&uuid, UUID_GATT);
service = gatt_db_add_service(database->db, &uuid, true, 4);
- database->gatt_handle = database_add_record(database, UUID_GATT,
- service,
+ database->gatt_handle = database_add_record(database, service,
"Generic Attribute Profile");
bt_uuid16_create(&uuid, GATT_CHARAC_SERVICE_CHANGED);
--
2.13.6
next reply other threads:[~2017-12-04 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 12:10 Luiz Augusto von Dentz [this message]
2017-12-04 12:10 ` [PATCH BlueZ 2/3] gatt: Use monitor code to decode service name Luiz Augusto von Dentz
2017-12-04 12:10 ` [PATCH BlueZ 3/3] gatt: Add all services as records Luiz Augusto von Dentz
2017-12-04 17:48 ` [PATCH BlueZ 1/3] gatt: Make database_add_record detect the UUID Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204121054.29186-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).