From: Johan Hedberg <johan.hedberg@gmail.com>
To: Steve Brown <sbrown@cortland.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: meshctl: Can't connect via Node Identity advertisement
Date: Mon, 4 Dec 2017 17:05:02 +0200 [thread overview]
Message-ID: <20171204150502.GA30627@x1c.home> (raw)
In-Reply-To: <1512395982.27418.14.camel@ewol.com>
Hi Steve,
On Mon, Dec 04, 2017, Steve Brown wrote:
> I added the command as you suggested.
>
> I had to change them to net-connect and node-connect because of command
> completion.
>
> If I issue a node-connect while the mesh-shell ident command is active,
> it connects.
>
> If you think there's interest, I'll post the patch.
I think we should definitely add support for this upstream, but after
thinking a bit more about it, maybe we could simply extend the existing
connect command instead of adding a new one. Node Identity is always in
the context of a given NetKey Index, so I think it'd be just as natural
to have a second optional parameter to the existing connect command
which would be the element address. If only one parameter is given then
meshctl looks for Net ID, if two are given it looks for Node ID. Sounds
reasonable?
Johan
next prev parent reply other threads:[~2017-12-04 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 23:39 meshctl: Can't connect via Node Identity advertisement Steve Brown
2017-12-04 12:36 ` Johan Hedberg
2017-12-04 13:06 ` Steve Brown
2017-12-04 13:59 ` Steve Brown
2017-12-04 15:05 ` Johan Hedberg [this message]
2017-12-04 15:21 ` Steve Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204150502.GA30627@x1c.home \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sbrown@cortland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).