From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-bluetooth-owner@vger.kernel.org>
Date: Fri, 8 Dec 2017 09:01:34 +0200
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 3/7] mesh: Make meshctl use bt_shell helpers
Message-ID: <20171208070134.GA29604@x1c.home>
References: <20171207122152.29743-1-luiz.dentz@gmail.com>
 <20171207122152.29743-3-luiz.dentz@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <20171207122152.29743-3-luiz.dentz@gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Luiz,

On Thu, Dec 07, 2017, Luiz Augusto von Dentz wrote:
> -static void set_scan_filter_uuids(const char *arg)
> +static void set_scan_filter_uuids(int argc, char *argv[])
>  {
>  	g_strfreev(filtered_scan_uuids);
>  	filtered_scan_uuids = NULL;
>  	filtered_scan_uuids_len = 0;
>  
> -	if (!arg || !strlen(arg))
> +	if (argc < 2 || !strlen(argv[1]))

This function seems to be called for string arrays like { UUID, NULL },
with argc == 1, so the above check looks broken to me. Actually, it
seems like this function is not used as a normal command handler, so why
is it dressed up like one (just causes confusion and potential bugs like
this)?

Johan