From: Johan Hedberg <johan.hedberg@gmail.com>
To: sbrown@cortland.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH V3 7/9] mesh: meshctl: Add get/set identity
Date: Sat, 16 Dec 2017 16:49:32 +0100 [thread overview]
Message-ID: <20171216154932.GA21312@x1c> (raw)
In-Reply-To: <20171215064606.15051-8-sbrown@cortland.com>
Hi Steve,
On Fri, Dec 15, 2017, sbrown@cortland.com wrote:
> + case OP_NODE_IDENTITY_STATUS:
> + if (len != 4)
> + return true;
> + bt_shell_printf("Network index 0x%04x has "
> + "Node Identity state 0x%02x %s\n",
> + get_le16(data + 1), data[3],
> + mesh_status_str(data[0]));
> +
> case OP_CONFIG_PROXY_STATUS:
This throws the following compilation error for me:
mesh/config-client.c: In function ‘client_msg_recvd’:
mesh/config-client.c:165:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
bt_shell_printf("Network index 0x%04x has "
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"Node Identity state 0x%02x %s\n",
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
get_le16(data + 1), data[3],
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mesh_status_str(data[0]));
~~~~~~~~~~~~~~~~~~~~~~~~~
mesh/config-client.c:170:2: note: here
case OP_CONFIG_RELAY_STATUS:
^~~~
cc1: all warnings being treated as errors
The above looks like a valid error, i.e. it seems there's a missing
break or return statement in your patch.
You might want to upgrade to a newer gcc version if you're not getting
these errors. At least version 7.2.1 from Fedora 27 give me these.
Johan
next prev parent reply other threads:[~2017-12-16 15:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 6:45 [PATCH V3 0/9] mesh: Add configuration commands to meshctl sbrown
2017-12-15 6:45 ` [PATCH V3 1/9] mesh: meshctl: Change command names to <cmd>-<get/set> sbrown
2017-12-15 6:45 ` [PATCH V3 2/9] mesh: meshctl: Add add/get subscribe sbrown
2017-12-15 6:46 ` [PATCH V3 3/9] mesh: meshctl: Add set heartbeat publish sbrown
2017-12-17 6:18 ` Stotland, Inga
2017-12-17 8:47 ` Steve Brown
2017-12-15 6:46 ` [PATCH V3 4/9] mesh: meshctl: Add get app keys sbrown
2017-12-15 6:46 ` [PATCH V3 5/9] mesh: meshctl: Add get publish sbrown
2017-12-15 6:46 ` [PATCH V3 6/9] mesh: meshctl: Add set/get proxy sbrown
2017-12-15 6:46 ` [PATCH V3 7/9] mesh: meshctl: Add get/set identity sbrown
2017-12-16 15:49 ` Johan Hedberg [this message]
2017-12-16 16:43 ` Steve Brown
2017-12-15 6:46 ` [PATCH V3 8/9] mesh: meshctl: Add get/set relay sbrown
2017-12-15 6:46 ` [PATCH V3 9/9] mesh: meshctl: Add Company ID parameter to pub-set and pub-get sbrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216154932.GA21312@x1c \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sbrown@cortland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).