From: Lukas Wunner <lukas@wunner.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Frederic Danis <frederic.danis.oss@gmail.com>,
Loic Poulain <loic.poulain@linaro.org>,
Hans de Goede <hdegoede@redhat.com>, Max Shavrick <mxms@me.com>,
Leif Liddy <leif.liddy@gmail.com>,
Daniel Roschka <danielroschka@phoenitydawn.de>,
Ronald Tschalaer <ronald@innovation.ch>,
"Peter Y. Chuang" <peteryuchuang@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 06/10] Bluetooth: hci_bcm: Silence IRQ printk
Date: Wed, 3 Jan 2018 14:56:53 +0100 [thread overview]
Message-ID: <20180103135653.GA31810@wunner.de> (raw)
In-Reply-To: <1514984939.7000.571.camel@linux.intel.com>
On Wed, Jan 03, 2018 at 03:08:59PM +0200, Andy Shevchenko wrote:
> On Tue, 2018-01-02 at 20:08 +0100, Lukas Wunner wrote:
> > @@ -798,7 +798,7 @@ static int bcm_get_resources(struct bcm_device
> > *dev)
> > dev->irq = gpiod_to_irq(gpio);
> > }
> >
> > - dev_info(dev->dev, "BCM irq: %d\n", dev->irq);
> > + dev_dbg(dev->dev, "BCM irq: %d\n", dev->irq);
>
> Perhaps, instead you may add same check
>
> if (dev->irq > 0)
> dev_info(...);
> else
> dev_info(..., "BCM irq not in use\n");
>
> ?
gpiod_to_irq() returns different negative errnos depending on the exact
error condition. We wouldn't be able to easily differentiate them if
we do it this way.
Thanks,
Lukas
next prev parent reply other threads:[~2018-01-03 13:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 19:08 [PATCH v2 00/10] Bluetooth on 2015+ MacBook (Pro) Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 04/10] Bluetooth: hci_bcm: Validate IRQ before using it Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 06/10] Bluetooth: hci_bcm: Silence IRQ printk Lukas Wunner
2018-01-03 13:08 ` Andy Shevchenko
2018-01-03 13:56 ` Lukas Wunner [this message]
2018-01-03 16:05 ` Andy Shevchenko
2018-01-02 19:08 ` [PATCH v2 07/10] Bluetooth: hci_bcm: Clean up unnecessary #ifdef Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 10/10] Bluetooth: hci_bcm: Support Apple GPIO handling Lukas Wunner
2018-01-03 12:55 ` Marcel Holtmann
2018-01-03 16:12 ` Andy Shevchenko
2018-01-02 19:08 ` [PATCH v2 03/10] Bluetooth: hci_bcm: Enable runtime PM despite absence of IRQ Lukas Wunner
2018-01-02 19:17 ` Hans de Goede
2018-01-02 23:36 ` Lukas Wunner
2018-01-03 8:07 ` Hans de Goede
2018-01-03 13:34 ` Lukas Wunner
2018-01-03 12:34 ` Marcel Holtmann
2018-01-03 13:22 ` Lukas Wunner
2018-01-03 13:29 ` Marcel Holtmann
2018-01-03 13:34 ` Lukas Wunner
2018-01-02 19:08 ` [PATCH v2 01/10] Bluetooth: Depend on rather than select GPIOLIB Lukas Wunner
2018-01-03 7:52 ` Linus Walleij
2018-01-05 18:27 ` Marcel Holtmann
2018-01-02 19:08 ` [PATCH v2 09/10] Bluetooth: hci_bcm: Handle errors properly Lukas Wunner
2018-01-03 16:08 ` Andy Shevchenko
2018-01-03 18:54 ` Lukas Wunner
2018-01-03 19:08 ` Andy Shevchenko
2018-01-02 19:08 ` [PATCH v2 05/10] Bluetooth: hci_bcm: Add helper to toggle device wake GPIO Lukas Wunner
2018-01-03 13:06 ` Andy Shevchenko
2018-01-02 19:08 ` [PATCH v2 02/10] Bluetooth: hci_bcm: Mandate presence of shutdown and " Lukas Wunner
2018-01-03 12:55 ` Marcel Holtmann
2018-01-02 19:08 ` [PATCH v2 08/10] Bluetooth: hci_bcm: Document struct bcm_device Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103135653.GA31810@wunner.de \
--to=lukas@wunner.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=danielroschka@phoenitydawn.de \
--cc=frederic.danis.oss@gmail.com \
--cc=hdegoede@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=leif.liddy@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=marcel@holtmann.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mxms@me.com \
--cc=peteryuchuang@gmail.com \
--cc=ronald@innovation.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).