From: Johan Hovold <johan@kernel.org>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Cc: marcel@holtmann.org, linux-renesas-soc@vger.kernel.org,
linux-serial@vger.kernel.org, johan@kernel.org, sre@kernel.org,
linux-bluetooth@vger.kernel.org, robh@kernel.org,
martin.blumenstingl@googlemail.com, gregkh@linuxfoundation.org,
magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com,
wsa@the-dreams.de, geert@linux-m68k.org
Subject: Re: [PATCH v2] serdev: add method to set parity
Date: Tue, 23 Jan 2018 12:34:34 +1100 [thread overview]
Message-ID: <20180123013434.GK3286@localhost> (raw)
In-Reply-To: <1516643792-22840-1-git-send-email-ulrich.hecht+renesas@gmail.com>
On Mon, Jan 22, 2018 at 06:56:32PM +0100, Ulrich Hecht wrote:
> Adds serdev_device_set_parity() and an implementation for ttyport.
> The interface uses an enum with the values SERIAL_PARITY_NONE,
> SERIAL_PARITY_EVEN and SERIAL_PARITY_ODD.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
>
> Hi!
>
> This revision addresses Johan's comments (see below for details) and adds
> Sebastian's Reviewed-by tag. Thank you for your reviews!
>
> CU
> Uli
>
>
> Changes since v1:
> - added Reviewed-by tag
> - expanded commit message
> - shuffled stuff around to keep line-setting bits together
> - clear CMSPAR
> - (hopefully) detect errors correctly by checking tty->termios after call
> to tty_set_termios().
Thanks for the v2. Looks good to me now.
Reviewed-by: Johan Hovold <johan@kernel.org>
Johan
next prev parent reply other threads:[~2018-01-23 1:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 17:56 [PATCH v2] serdev: add method to set parity Ulrich Hecht
2018-01-22 18:23 ` Marcel Holtmann
2018-01-23 7:00 ` Greg Kroah-Hartman
2018-01-23 1:34 ` Johan Hovold [this message]
2018-01-23 8:16 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123013434.GK3286@localhost \
--to=johan@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=marcel@holtmann.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox