From: Arnd Bergmann <arnd@arndb.de>
To: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Tedd Ho-Jeong An <tedd.an@linux.intel.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Bluetooth: btintel: remove extraneous semicolon
Date: Fri, 26 Jan 2018 14:06:39 +0100 [thread overview]
Message-ID: <20180126130652.3499127-1-arnd@arndb.de> (raw)
The newly added btintel_download_firmware() dummy helper definition is
incorrect, causing a build error when CONFIG_BT_INTEL is disabled:
In file included from drivers/bluetooth/hci_ldisc.c:49:0:
drivers/bluetooth/btintel.h:196:1: error: expected identifier or '(' before '{' token
drivers/bluetooth/btintel.h:193:19: error: 'btintel_download_firmware' declared 'static' but never defined [-Werror=unused-function]
Removing the semicolon makes it work again.
Fixes: 0bd4ded3287d ("Bluetooth: btintel: Create common function for firmware download")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/bluetooth/btintel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
index 01728e212267..41c642cc523f 100644
--- a/drivers/bluetooth/btintel.h
+++ b/drivers/bluetooth/btintel.h
@@ -192,7 +192,7 @@ static inline int btintel_read_boot_params(struct hci_dev *hdev,
static inline int btintel_download_firmware(struct hci_dev *dev,
const struct firmware *fw,
- u32 *boot_param);
+ u32 *boot_param)
{
return -EOPNOTSUPP;
}
--
2.9.0
next reply other threads:[~2018-01-26 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 13:06 Arnd Bergmann [this message]
2018-01-26 15:22 ` [PATCH] Bluetooth: btintel: remove extraneous semicolon Marcel Holtmann
2018-01-26 16:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126130652.3499127-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=tedd.an@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox