From: Johan Hedberg <johan.hedberg@gmail.com>
To: Szymon Janc <szymon.janc@codecoup.pl>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] adapter: Fix not clearing connectable setting on power off
Date: Mon, 19 Feb 2018 19:16:20 +0200 [thread overview]
Message-ID: <20180219171620.GA21899@x1c.home> (raw)
In-Reply-To: <20180219124335.16528-1-szymon.janc@codecoup.pl>
Hi Szymon,
On Mon, Feb 19, 2018, Szymon Janc wrote:
> When kernel control of connectable is used daemon doesn't enable
> connectable setting unless discoverable. Both settings are permanent
> over power toggle unless discoverable timeout was set. In that case
> discoverable flag is cleared by kernel on power off. This leads to
> connectable flag being left enabled when toggling power on discoverable
> adapter with timeout set.
>
> This has some implications on system behaviour:
> - accepting connection from unknown devices
> - not being able to advertise as broadcaster
>
> Since kernel doens't know the reason for enabling connectable flag (and
> thus if disable if on power off) this needs to be handled in bluetoothd.
> ---
> src/adapter.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
Applied. Thanks.
Johan
prev parent reply other threads:[~2018-02-19 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 12:43 [PATCH v2] adapter: Fix not clearing connectable setting on power off Szymon Janc
2018-02-19 17:16 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219171620.GA21899@x1c.home \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@codecoup.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).